Patchwork [v11,2/9] libata: Add CONFIG_SATA_ZPODD

login
register
mail settings
Submitter Aaron Lu
Date Jan. 6, 2013, 2:48 a.m.
Message ID <1357440509-28108-3-git-send-email-aaron.lu@intel.com>
Download mbox | patch
Permalink /patch/209716/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Aaron Lu - Jan. 6, 2013, 2:48 a.m.
Added a new config CONFIG_SATA_ZPODD, which is used to support
SATA based zero power ODD(ZPODD), and depends on ATA_ACPI.

Signed-off-by: Aaron Lu <aaron.lu@intel.com>
---
 drivers/ata/Kconfig  | 13 +++++++++++++
 drivers/ata/Makefile |  1 +
 2 files changed, 14 insertions(+)
Tejun Heo - Jan. 7, 2013, 6:06 p.m.
On Sun, Jan 06, 2013 at 10:48:22AM +0800, Aaron Lu wrote:
> Added a new config CONFIG_SATA_ZPODD, which is used to support
> SATA based zero power ODD(ZPODD), and depends on ATA_ACPI.
> 
> Signed-off-by: Aaron Lu <aaron.lu@intel.com>

Maybe just fold this into the next patch?  It's rather unconventional
to introduce the config option and makefile changes by themselves.

Thanks.

Patch

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index e08d322..996d16c 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -58,6 +58,19 @@  config ATA_ACPI
 	  You can disable this at kernel boot time by using the
 	  option libata.noacpi=1
 
+config SATA_ZPODD
+	bool "SATA Zero Power ODD Support"
+	depends on ATA_ACPI
+	default n
+	help
+	  This option adds support for SATA ZPODD. It requires both
+	  ODD and the platform support, and if enabled, will automatically
+	  power on/off the ODD when certain condition is satisfied. This
+	  does not impact user's experience of the ODD, only power is saved
+	  when ODD is not in use(i.e. no disc inside).
+
+	  If unsure, say N.
+
 config SATA_PMP
 	bool "SATA Port Multiplier support"
 	default y
diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
index 9329daf..85e3de4 100644
--- a/drivers/ata/Makefile
+++ b/drivers/ata/Makefile
@@ -107,3 +107,4 @@  libata-y	:= libata-core.o libata-scsi.o libata-eh.o libata-transport.o
 libata-$(CONFIG_ATA_SFF)	+= libata-sff.o
 libata-$(CONFIG_SATA_PMP)	+= libata-pmp.o
 libata-$(CONFIG_ATA_ACPI)	+= libata-acpi.o
+libata-$(CONFIG_SATA_ZPODD)	+= libata-zpodd.o