From patchwork Sat Jan 5 09:57:31 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: ethtool: Add version check for et131x regs From: Mark Einon X-Patchwork-Id: 209657 Message-Id: <1357379851-5298-1-git-send-email-mark.einon@gmail.com> To: bhutchings@solarflare.com Cc: netdev@vger.kernel.org, Mark Einon Date: Sat, 5 Jan 2013 09:57:31 +0000 Added a version check for the et131x reg dump, in case the dump format needs to be changed later. Signed-off-by: Mark Einon --- et131x.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/et131x.c b/et131x.c index b36c184..8cdbec0 100644 --- a/et131x.c +++ b/et131x.c @@ -4,8 +4,12 @@ int et131x_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs) { + u8 version = (u8)(regs->version >> 24); u32 *reg = (u32 *)regs->data; + if(version != 1) + return -1; + fprintf(stdout, "PHY Registers\n"); fprintf(stdout, "0x0, Basic Control Reg = 0x%04X\n", *reg++); fprintf(stdout, "0x1, Basic Status Reg = 0x%04X\n", *reg++);