From patchwork Sat Jan 5 09:57:31 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Einon X-Patchwork-Id: 209657 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id B2D3C2C0085 for ; Sat, 5 Jan 2013 21:19:38 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755570Ab3AEKTg (ORCPT ); Sat, 5 Jan 2013 05:19:36 -0500 Received: from mail-wg0-f48.google.com ([74.125.82.48]:43973 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755501Ab3AEKTf (ORCPT ); Sat, 5 Jan 2013 05:19:35 -0500 Received: by mail-wg0-f48.google.com with SMTP id dt10so8162550wgb.27 for ; Sat, 05 Jan 2013 02:19:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer; bh=EfHY8c4o/Z6WgcruGfD8MtNMnA+YWyt7b0cHXZ0exYw=; b=ygZKA/sfoHRMUyeQuh2BkoULUDUCOfQUGLoA4YfwL2gPIyIfE9GzWI3XT7YfV8ORu8 WqiJXLjwy6+CcyhLlHReaafA1zqRz/uBfocMp0JBvYtrWPOwC8EHEUXk+XSVbPgcnmzP Iirs1RHaJQCVyl+yrfVAI9MqgEBQ7fQc/+s0OB4/7Gh8ys1d6rzMnU5qNNoHSzyhXAL5 8i6oXB+VqEXpYbjE9BL09sydwo4F3fxZ3ArZOaidAX/c2gMiVA0riVy4Zg4u5fVn9crf MmAAkdG/xq70jypYBkBCRYnL71tBMOau4dlV/sjmiDk/HTfPRfsenlLhBiUNHO/qdOpe P/yA== X-Received: by 10.194.19.10 with SMTP id a10mr87572247wje.45.1357379857199; Sat, 05 Jan 2013 01:57:37 -0800 (PST) Received: from localhost.localdomain ([146.90.162.255]) by mx.google.com with ESMTPS id t17sm2852150wiv.6.2013.01.05.01.57.35 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 05 Jan 2013 01:57:36 -0800 (PST) From: Mark Einon To: bhutchings@solarflare.com Cc: netdev@vger.kernel.org, Mark Einon Subject: [PATCH] ethtool: Add version check for et131x regs Date: Sat, 5 Jan 2013 09:57:31 +0000 Message-Id: <1357379851-5298-1-git-send-email-mark.einon@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Added a version check for the et131x reg dump, in case the dump format needs to be changed later. Signed-off-by: Mark Einon --- et131x.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/et131x.c b/et131x.c index b36c184..8cdbec0 100644 --- a/et131x.c +++ b/et131x.c @@ -4,8 +4,12 @@ int et131x_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs) { + u8 version = (u8)(regs->version >> 24); u32 *reg = (u32 *)regs->data; + if(version != 1) + return -1; + fprintf(stdout, "PHY Registers\n"); fprintf(stdout, "0x0, Basic Control Reg = 0x%04X\n", *reg++); fprintf(stdout, "0x1, Basic Status Reg = 0x%04X\n", *reg++);