Patchwork hw/i386: Fix broken build for MinGW

login
register
mail settings
Submitter Stefan Weil
Date Jan. 4, 2013, 9:57 p.m.
Message ID <1357336668-15518-1-git-send-email-sw@weilnetz.de>
Download mbox | patch
Permalink /patch/209552/
State Superseded
Headers show

Comments

Stefan Weil - Jan. 4, 2013, 9:57 p.m.
pc-testdev.c cannot be compiled with MinGW:

  CC    i386-softmmu/hw/i386/../pc-testdev.o
hw/i386/../pc-testdev.c:38:22: warning: sys/mman.h: file not found
hw/i386/../pc-testdev.c: In function ‘test_flush_page’:
hw/i386/../pc-testdev.c:103: warning: implicit declaration of function ‘mprotect’
...

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 hw/i386/Makefile.objs |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Gerd Hoffmann - Jan. 7, 2013, 8:35 a.m.
On 01/04/13 22:57, Stefan Weil wrote:
> pc-testdev.c cannot be compiled with MinGW:
> 
>   CC    i386-softmmu/hw/i386/../pc-testdev.o
> hw/i386/../pc-testdev.c:38:22: warning: sys/mman.h: file not found
> hw/i386/../pc-testdev.c: In function ‘test_flush_page’:
> hw/i386/../pc-testdev.c:103: warning: implicit declaration of function ‘mprotect’
> ...

> +obj-$(CONFIG_KVM) += pc-testdev.o

CONFIG_POSIX is the better choice I think.

cheers,
  Gerd
Stefan Weil - Jan. 7, 2013, 5:16 p.m.
Am 07.01.2013 09:35, schrieb Gerd Hoffmann:
> On 01/04/13 22:57, Stefan Weil wrote:
>> pc-testdev.c cannot be compiled with MinGW:
>>
>>    CC    i386-softmmu/hw/i386/../pc-testdev.o
>> hw/i386/../pc-testdev.c:38:22: warning: sys/mman.h: file not found
>> hw/i386/../pc-testdev.c: In function ‘test_flush_page’:
>> hw/i386/../pc-testdev.c:103: warning: implicit declaration of function ‘mprotect’
>> ...
>
>> +obj-$(CONFIG_KVM) += pc-testdev.o
>
> CONFIG_POSIX is the better choice I think.
>
> cheers,
>    Gerd

I agree.

This patch was superseded by a newer one which indeed uses
CONFIG_POSIX and was applied by Blue, see

http://patchwork.ozlabs.org/patch/209653/

Cheers,
Stefan
Lucas Meneghel Rodrigues - Jan. 7, 2013, 6:14 p.m.
On 01/07/2013 03:16 PM, Stefan Weil wrote:
> Am 07.01.2013 09:35, schrieb Gerd Hoffmann:
>> On 01/04/13 22:57, Stefan Weil wrote:
>>> pc-testdev.c cannot be compiled with MinGW:
>>>
>>>    CC    i386-softmmu/hw/i386/../pc-testdev.o
>>> hw/i386/../pc-testdev.c:38:22: warning: sys/mman.h: file not found
>>> hw/i386/../pc-testdev.c: In function ‘test_flush_page’:
>>> hw/i386/../pc-testdev.c:103: warning: implicit declaration of
>>> function ‘mprotect’
>>> ...
>>
>>> +obj-$(CONFIG_KVM) += pc-testdev.o
>>
>> CONFIG_POSIX is the better choice I think.
>>
>> cheers,
>>    Gerd
>
> I agree.
>
> This patch was superseded by a newer one which indeed uses
> CONFIG_POSIX and was applied by Blue, see
>
> http://patchwork.ozlabs.org/patch/209653/
>
> Cheers,
> Stefan

Ok, sorry about that, guys, and thanks for fixing things.

Lucas

Patch

diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs
index 025803a..8f17763 100644
--- a/hw/i386/Makefile.objs
+++ b/hw/i386/Makefile.objs
@@ -12,6 +12,6 @@  obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen-host-pci-device.o
 obj-$(CONFIG_XEN_PCI_PASSTHROUGH) += xen_pt.o xen_pt_config_init.o xen_pt_msi.o
 obj-y += kvm/
 obj-$(CONFIG_SPICE) += qxl.o qxl-logger.o qxl-render.o
-obj-y += pc-testdev.o
+obj-$(CONFIG_KVM) += pc-testdev.o
 
 obj-y := $(addprefix ../,$(obj-y))