From patchwork Fri Jan 4 18:23:26 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris J Arges X-Patchwork-Id: 209512 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id 6127C2C0080 for ; Sat, 5 Jan 2013 05:23:36 +1100 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1TrBvS-0005nQ-F8; Fri, 04 Jan 2013 18:23:26 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1TrBvQ-0005mp-PE for kernel-team@lists.ubuntu.com; Fri, 04 Jan 2013 18:23:24 +0000 Received: from cpe-70-112-44-241.austin.res.rr.com ([70.112.44.241] helo=[192.168.1.117]) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1TrBvQ-0003fx-Jo for kernel-team@lists.ubuntu.com; Fri, 04 Jan 2013 18:23:24 +0000 Message-ID: <50E71E1E.9090204@canonical.com> Date: Fri, 04 Jan 2013 12:23:26 -0600 From: Chris J Arges User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Ubuntu Kernel Team Subject: [quantal/precise][sru] LP#1096137-- fsnotify: simplify locking X-Enigmail-Version: 1.4.6 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.13 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kernel-team-bounces@lists.ubuntu.com Errors-To: kernel-team-bounces@lists.ubuntu.com Note this updates the fixes in 922906 with the proper mainline patches. Tim asked that I re-submit this as a new bug. BugLink: http://bugs.launchpad.net/bugs/1096137 SRU Justification: Impact: When plugging and unplugging a USB drive occasionally a race condition in the notify subsystem causes a kernel oops. Fix: A set of patches from upstream address this issue, this should already be present in raring. Here are the commit hashes: 6960b0d909cde5bdff49e4e5c1250edd10be7ebd 64c20d2a20fce295c260ea6cb3b468edfa2fb07b d5a335b845792d2a69ed1e244c0b233117b7db3c e2a29943e9a2ee2aa737a77f550f46ba72269db4 (backported) 986ab09807ca9454c3f54aae4db7e1bb00daeed3 6dfbd149946c22c2e2886d6b560def78630c8387 104d06f08ea59247cb0e7e548c5a5d22d21dcfd5 23e964c284ca0a767b80a30482bd53b059d30391 986129520479d689962a42c31acdeaf854ac91f5 Testcase: Comment #8 and #9 in the upstream bug: https://bugzilla.kernel.org/show_bug.cgi?id=22602 has a test case that easily reproduces this issue within 15-30 minutes. I have applied the above fixes and was able to run this test case overnight in all cases. In addition I've tested using the LTP tests for inotfy and these run properly with the fix applied. --- The following changes since commit 517fd8561b857c856d4a8663ca2f4594d7c40288: UBUNTU: Ubuntu-3.2.0-36.56 (2013-01-02 12:38:18 -0800) are available in the git repository at: git://kernel.ubuntu.com/arges/ubuntu-precise.git lp1096137 for you to fetch changes up to 0b0a002c6793cfa9c7a18e5b1d904740710b5f39: fsnotify: change locking order (2013-01-04 12:15:37 -0600) ---------------------------------------------------------------- The following changes since commit de8dfe4a5e90bfa14e65dd7d1da30558223e950b: UBUNTU: Ubuntu-3.5.0-22.33 (2013-01-02 12:37:49 -0800) are available in the git repository at: git://kernel.ubuntu.com/arges/ubuntu-quantal.git lp1096137 for you to fetch changes up to 681456fdd22608d37d60244fc18095ebea383d37: fsnotify: change locking order (2013-01-04 11:44:16 -0600) ----------------------------------------------------------------