Patchwork [quantal/precise,sru] LP#1096137-- fsnotify: simplify locking

login
register
mail settings
Submitter Chris J Arges
Date Jan. 4, 2013, 6:23 p.m.
Message ID <50E71E1E.9090204@canonical.com>
Download mbox
Permalink /patch/209512/
State New
Headers show

Pull-request

git://kernel.ubuntu.com/arges/ubuntu-quantal.git lp1096137

Comments

Chris J Arges - Jan. 4, 2013, 6:23 p.m.
Note this updates the fixes in 922906 with the proper mainline patches.
Tim asked that I re-submit this as a new bug.

BugLink: http://bugs.launchpad.net/bugs/1096137

SRU Justification:

Impact:
When plugging and unplugging a USB drive occasionally a race condition
in the notify subsystem causes a kernel oops.

Fix:
A set of patches from upstream address this issue, this should already
be present in raring.

Here are the commit hashes:
6960b0d909cde5bdff49e4e5c1250edd10be7ebd
64c20d2a20fce295c260ea6cb3b468edfa2fb07b
d5a335b845792d2a69ed1e244c0b233117b7db3c
e2a29943e9a2ee2aa737a77f550f46ba72269db4 (backported)
986ab09807ca9454c3f54aae4db7e1bb00daeed3
6dfbd149946c22c2e2886d6b560def78630c8387
104d06f08ea59247cb0e7e548c5a5d22d21dcfd5
23e964c284ca0a767b80a30482bd53b059d30391
986129520479d689962a42c31acdeaf854ac91f5

Testcase:
Comment #8 and #9 in the upstream bug:
https://bugzilla.kernel.org/show_bug.cgi?id=22602 has a test case that
easily reproduces this issue within 15-30 minutes. I have applied the
above fixes and was able to run this test case overnight in all cases.
In addition I've tested using the LTP tests for inotfy and these run
properly with the fix applied.

--

The following changes since commit 517fd8561b857c856d4a8663ca2f4594d7c40288:

  UBUNTU: Ubuntu-3.2.0-36.56 (2013-01-02 12:38:18 -0800)

are available in the git repository at:

  git://kernel.ubuntu.com/arges/ubuntu-precise.git lp1096137

for you to fetch changes up to 0b0a002c6793cfa9c7a18e5b1d904740710b5f39:

  fsnotify: change locking order (2013-01-04 12:15:37 -0600)

----------------------------------------------------------------

The following changes since commit de8dfe4a5e90bfa14e65dd7d1da30558223e950b:

  UBUNTU: Ubuntu-3.5.0-22.33 (2013-01-02 12:37:49 -0800)

are available in the git repository at:

  git://kernel.ubuntu.com/arges/ubuntu-quantal.git lp1096137

for you to fetch changes up to 681456fdd22608d37d60244fc18095ebea383d37:

  fsnotify: change locking order (2013-01-04 11:44:16 -0600)

----------------------------------------------------------------
Tim Gardner - Jan. 4, 2013, 7:38 p.m.
I've applied these patches without 2 ACKs since they have already been
reviewed in a previous incarnation, they are (with one exception) clean
cherry picks, and have good test results.

rtg