Patchwork [4/9] target-i386: check/enforce: Do not ignore "hypervisor" flag

login
register
mail settings
Submitter Eduardo Habkost
Date Jan. 4, 2013, 3:37 p.m.
Message ID <1357313864-31026-5-git-send-email-ehabkost@redhat.com>
Download mbox | patch
Permalink /patch/209480/
State New
Headers show

Comments

Eduardo Habkost - Jan. 4, 2013, 3:37 p.m.
We don't need any hack to ignore CPUID_EXT_HYPERVISOR anymore, because
kvm_arch_get_supported_cpuid() now set CPUID_EXT_HYPERVISOR properly.
So, this shouldn't introduce any behavior change, but it makes the code
simpler.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
My goal is to eliminate the check_feat field completely, as
kvm_arch_get_supported_cpuid() should now really return all the bits we
can set on all CPUID leaves.
---
 target-i386/cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 6c43ace..f1a21cf 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -965,7 +965,7 @@  static int kvm_check_features_against_host(x86_def_t *guest_def)
         {&guest_def->features, &host_def.features,
             ~0, feature_name, 0x00000001, R_EDX},
         {&guest_def->ext_features, &host_def.ext_features,
-            ~CPUID_EXT_HYPERVISOR, ext_feature_name, 0x00000001, R_ECX},
+            ~0, ext_feature_name, 0x00000001, R_ECX},
         {&guest_def->ext2_features, &host_def.ext2_features,
             ~PPRO_FEATURES, ext2_feature_name, 0x80000001, R_EDX},
         {&guest_def->ext3_features, &host_def.ext3_features,