Patchwork Clarify error message (PR middle-end/55859)

login
register
mail settings
Submitter Marek Polacek
Date Jan. 4, 2013, 11:05 a.m.
Message ID <20130104110549.GB6721@redhat.com>
Download mbox | patch
Permalink /patch/209444/
State New
Headers show

Comments

Marek Polacek - Jan. 4, 2013, 11:05 a.m.
On Fri, Jan 04, 2013 at 11:42:24AM +0100, Jakub Jelinek wrote:
> I wonder what is the point of using %qs with a fixed string, and ' should be
> probably replaced by %< and %>, so perhaps
> 		"argument to %<-O%> should be a non-negative integer, "
> 		"%<s%>, %<g%> or %<fast%>");

So, like this?

2013-01-04  Marek Polacek  <polacek@redhat.com>

	* opts.c (default_options_optimization): Clarify error message.


	Marek
Jakub Jelinek - Jan. 4, 2013, 11:06 a.m.
On Fri, Jan 04, 2013 at 12:05:49PM +0100, Marek Polacek wrote:
> On Fri, Jan 04, 2013 at 11:42:24AM +0100, Jakub Jelinek wrote:
> > I wonder what is the point of using %qs with a fixed string, and ' should be
> > probably replaced by %< and %>, so perhaps
> > 		"argument to %<-O%> should be a non-negative integer, "
> > 		"%<s%>, %<g%> or %<fast%>");
> 
> So, like this?

Yes, thanks.

	Jakub

Patch

--- gcc/opts.c.mp	2013-01-04 02:48:33.116785922 +0100
+++ gcc/opts.c	2013-01-04 12:00:15.983233160 +0100
@@ -1,7 +1,6 @@ 
 /* Command line option handling.
    Copyright (C) 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011,
-   2012
-
+   2012, 2013
    Free Software Foundation, Inc.
    Contributed by Neil Booth.
 
@@ -542,9 +541,8 @@  default_options_optimization (struct gcc
 	    {
 	      const int optimize_val = integral_argument (opt->arg);
 	      if (optimize_val == -1)
-		error_at (loc,
-			  "argument to %qs should be a non-negative integer",
-			  "-O");
+		error_at (loc, "argument to %<-O%> should be a non-negative "
+			       "integer, %<g%>, %<s%> or %<fast%>");
 	      else
 		{
 		  opts->x_optimize = optimize_val;