Patchwork [PULL,0/4] test and debug devices

login
register
mail settings
Submitter Gerd Hoffmann
Date Jan. 4, 2013, 8:16 a.m.
Message ID <1357287364-24921-1-git-send-email-kraxel@redhat.com>
Download mbox
Permalink /patch/209381/
State New
Headers show

Pull-request

git://git.kraxel.org/qemu testdev.1

Comments

Gerd Hoffmann - Jan. 4, 2013, 8:16 a.m.
Hi,

This patch series improves the debug devices we have.  isa-debugcon is
switched over to the memory api.  isa-debug-exit is added and replaces
the hard-coded bochs debug port.  pc-testdev (used by kvm-unit-tests) is
added.

please pull,
  Gerd

The following changes since commit 25bbf61e4bacd1e4fa4115ffcf151051b9d6608e:

  pty: unbreak libvirt (2013-01-03 12:53:41 -0600)

are available in the git repository at:
  git://git.kraxel.org/qemu testdev.1

Gerd Hoffmann (3):
      switch debugcon to memory api
      add isa-debug-exit device.
      pc: remove bochs bios debug ports

Lucas Meneghel Rodrigues (1):
      hw: Add test device for unittests execution

 hw/debugcon.c         |   31 +++++++--
 hw/debugexit.c        |   75 ++++++++++++++++++++
 hw/i386/Makefile.objs |    3 +-
 hw/pc-testdev.c       |  182 +++++++++++++++++++++++++++++++++++++++++++++++++
 hw/pc.c               |   41 -----------
 5 files changed, 283 insertions(+), 49 deletions(-)
 create mode 100644 hw/debugexit.c
 create mode 100644 hw/pc-testdev.c
Andreas Färber - Jan. 4, 2013, 10:28 a.m.
Am 04.01.2013 09:16, schrieb Gerd Hoffmann:
>   Hi,
> 
> This patch series improves the debug devices we have.  isa-debugcon is
> switched over to the memory api.  isa-debug-exit is added and replaces
> the hard-coded bochs debug port.  pc-testdev (used by kvm-unit-tests) is
> added.

Missing some CCs, and I was actually expecting another PATCH series
first... as brought up before it is refreshing an uncommitted series by
Hervé without any mention thereof in the commit message and I thought
there was an unanswered question to Anthony on both Lucas' and Hervé's
series?

Andreas

> 
> please pull,
>   Gerd
> 
> The following changes since commit 25bbf61e4bacd1e4fa4115ffcf151051b9d6608e:
> 
>   pty: unbreak libvirt (2013-01-03 12:53:41 -0600)
> 
> are available in the git repository at:
>   git://git.kraxel.org/qemu testdev.1
> 
> Gerd Hoffmann (3):
>       switch debugcon to memory api
>       add isa-debug-exit device.
>       pc: remove bochs bios debug ports
> 
> Lucas Meneghel Rodrigues (1):
>       hw: Add test device for unittests execution
> 
>  hw/debugcon.c         |   31 +++++++--
>  hw/debugexit.c        |   75 ++++++++++++++++++++
>  hw/i386/Makefile.objs |    3 +-
>  hw/pc-testdev.c       |  182 +++++++++++++++++++++++++++++++++++++++++++++++++
>  hw/pc.c               |   41 -----------
>  5 files changed, 283 insertions(+), 49 deletions(-)
>  create mode 100644 hw/debugexit.c
>  create mode 100644 hw/pc-testdev.c
Gerd Hoffmann - Jan. 4, 2013, 12:57 p.m.
Hi,

>> This patch series improves the debug devices we have.  isa-debugcon is
>> switched over to the memory api.  isa-debug-exit is added and replaces
>> the hard-coded bochs debug port.  pc-testdev (used by kvm-unit-tests) is
>> added.
> 
> Missing some CCs, and I was actually expecting another PATCH series
> first... as brought up before it is refreshing an uncommitted series by
> Hervé without any mention thereof in the commit message

Hmm?  The isa-debug-exit patch is written by myself.  After hacking it
up I've noticed Herve wrote a simliar one.  But I didn't grab Herve's
patch.  I've picked up + updated Lucas' testdev patch, and that is
clearly visible in the commit message.

> and I thought
> there was an unanswered question to Anthony on both Lucas' and Hervé's
> series?

The only outstanding question I'm aware of is whenever anthony does a
outb or outw on the bochs debug port in his test suite.  My
isa-debug-exit device handles both cases, so we should be fine here, and
I'm sure Anthony will actually try before committing the series ;)

What else is unanswered?

cheers,
  Gerd
Andreas Färber - Jan. 4, 2013, 1:07 p.m.
Hi Gerd,

Am 04.01.2013 13:57, schrieb Gerd Hoffmann:
>>> This patch series improves the debug devices we have.  isa-debugcon is
>>> switched over to the memory api.  isa-debug-exit is added and replaces
>>> the hard-coded bochs debug port.  pc-testdev (used by kvm-unit-tests) is
>>> added.
>>
>> Missing some CCs, and I was actually expecting another PATCH series
>> first... as brought up before it is refreshing an uncommitted series by
>> Hervé without any mention thereof in the commit message
> 
> Hmm?  The isa-debug-exit patch is written by myself.  After hacking it
> up I've noticed Herve wrote a simliar one.  But I didn't grab Herve's
> patch.  I've picked up + updated Lucas' testdev patch, and that is
> clearly visible in the commit message.
> 
>> and I thought
>> there was an unanswered question to Anthony on both Lucas' and Hervé's
>> series?
> 
> The only outstanding question I'm aware of is whenever anthony does a
> outb or outw on the bochs debug port in his test suite.  My
> isa-debug-exit device handles both cases, so we should be fine here, and
> I'm sure Anthony will actually try before committing the series ;)
> 
> What else is unanswered?

I believe the original unanswered question was whether it is okay for
Anthony to add -device foo for his testing now that the default port was
changed to what he was relying on or whether he wants it to
automatically get instantiated for machine backwards compatibility
unless --no-defaults (or whatever it's called) is used. Your series,
just like Hervé's that got stopped by Anthony, simple moves things into
a standalone device in 2/4 and I don't see any pc-1.3 handling in 4/4.

Cheers,
Andreas
Anthony Liguori - Jan. 4, 2013, 1:45 p.m.
Gerd Hoffmann <kraxel@redhat.com> writes:

>   Hi,
>
>>> This patch series improves the debug devices we have.  isa-debugcon is
>>> switched over to the memory api.  isa-debug-exit is added and replaces
>>> the hard-coded bochs debug port.  pc-testdev (used by kvm-unit-tests) is
>>> added.
>> 
>> Missing some CCs, and I was actually expecting another PATCH series
>> first... as brought up before it is refreshing an uncommitted series by
>> Hervé without any mention thereof in the commit message
>
> Hmm?  The isa-debug-exit patch is written by myself.  After hacking it
> up I've noticed Herve wrote a simliar one.  But I didn't grab Herve's
> patch.  I've picked up + updated Lucas' testdev patch, and that is
> clearly visible in the commit message.
>
>> and I thought
>> there was an unanswered question to Anthony on both Lucas' and Hervé's
>> series?
>
> The only outstanding question I'm aware of is whenever anthony does a
> outb or outw on the bochs debug port in his test suite.

outb.

Regards,

Anthony Liguori

> My
> isa-debug-exit device handles both cases, so we should be fine here, and
> I'm sure Anthony will actually try before committing the series ;)
>
> What else is unanswered?
>
> cheers,
>   Gerd
Anthony Liguori - Jan. 4, 2013, 8:21 p.m.
Pulled, thanks.

N.B.  This note may be extraneous because the pull request was sent by a
version of git older than 1.7.9 making the pull request ambigious.  Please
consider upgrading to a newer version of git.

Regards,

Anthony Liguori