From patchwork Thu Jan 3 09:35:23 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [U-Boot, V2] drivers/block/systemace - added missing "else" in "ace_writew" Date: Wed, 02 Jan 2013 23:35:23 -0000 From: Alexey Brodkin X-Patchwork-Id: 209203 Message-Id: <1357205723-5022-1-git-send-email-alexey.brodkin@gmail.com> To: u-boot@lists.denx.de Cc: fdols@synopsys.com System ACE compact flash controller supports either 8-bit (default) or 16-bit data transfers. And in corresponding driver we need to implement read/write of 16-bit data words properly for both modes of operation. In existing code if width==8 both branches get executed which may cause unexpected behavior of SystemAce controller. Addition of "else" fixes described issue and execution is done as expected for both (8-bit and 16-bit) data bus widths. Signed-off-by: Alexey Brodkin Acked-by: Michal Simek --- drivers/block/systemace.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/block/systemace.c b/drivers/block/systemace.c index 247cf06..27cacdf 100644 --- a/drivers/block/systemace.c +++ b/drivers/block/systemace.c @@ -66,7 +66,8 @@ static void ace_writew(u16 val, unsigned off) writeb(val >> 8, base + off + 1); #endif } - out16(base + off, val); + else + out16(base + off, val); } static u16 ace_readw(unsigned off)