Patchwork [RFC,net-next,3/3] vxlan: remove NETIF_F_NETNS_LOCAL from vxlan device features.

login
register
mail settings
Submitter Rami Rosen
Date Jan. 3, 2013, 9:25 a.m.
Message ID <1357205121-4700-4-git-send-email-ramirose@gmail.com>
Download mbox | patch
Permalink /patch/209202/
State RFC
Delegated to: David Miller
Headers show

Comments

Rami Rosen - Jan. 3, 2013, 9:25 a.m.
There is no need for NETIF_F_NETNS_LOCAL for vxlan device; this patch removes it.

Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
 drivers/net/vxlan.c | 1 -
 1 file changed, 1 deletion(-)
stephen hemminger - Jan. 3, 2013, 3:45 p.m.
On Thu,  3 Jan 2013 11:25:21 +0200
Rami Rosen <ramirose@gmail.com> wrote:

> There is no need for NETIF_F_NETNS_LOCAL for vxlan device; this patch removes it.
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
>  drivers/net/vxlan.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index 40f2cc1..385f743 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -1185,7 +1185,6 @@ static void vxlan_setup(struct net_device *dev)
>  
>  	dev->tx_queue_len = 0;
>  	dev->features	|= NETIF_F_LLTX;
> -	dev->features	|= NETIF_F_NETNS_LOCAL;
>  	dev->features	|= NETIF_F_SG | NETIF_F_HW_CSUM;
>  	dev->features   |= NETIF_F_RXCSUM;
>  

Vxlan works over UDP socket, and the UDP socket is part of the namespace
it is created in. Moving the vxlan device does not move that state.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 40f2cc1..385f743 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -1185,7 +1185,6 @@  static void vxlan_setup(struct net_device *dev)
 
 	dev->tx_queue_len = 0;
 	dev->features	|= NETIF_F_LLTX;
-	dev->features	|= NETIF_F_NETNS_LOCAL;
 	dev->features	|= NETIF_F_SG | NETIF_F_HW_CSUM;
 	dev->features   |= NETIF_F_RXCSUM;