Patchwork Re: [PATCH V2] rtc: add RTC driver for TPS6586x

login
register
mail settings
Submitter Andrew Morton
Date Jan. 2, 2013, 11:50 p.m.
Message ID <20130102155057.9fb6ede2.akpm@linux-foundation.org>
Download mbox | patch
Permalink /patch/209160/
State New
Headers show

Comments

Andrew Morton - Jan. 2, 2013, 11:50 p.m.
On Thu, 27 Dec 2012 20:29:14 +0530
Laxman Dewangan <ldewangan@nvidia.com> wrote:

> On Thursday 27 December 2012 08:26 PM, Marc Dietrich wrote:
> > Hi Laxman,
> >
> > On Friday 21 December 2012 20:42:28 you wrote:
> >
> >> +
> >> +	/* Set epoch start as 00:00:00:01:01:2000 */
> >> +	rtc->epoch_start = mktime(2000, 1, 1, 0, 0, 0);
> > any reason why you hard coded it to 2000? All boards I know use 2009, so with
> > this patch, everyone needs to set his clock again.
> >
> 
> No specific reason. If 2009 should be default then I can push patch to 
> set it as 2009.

I'd like to get this into Linus soon so let's get it finished.  I
assume it's merely this?
Laxman Dewangan - Jan. 3, 2013, 6:16 a.m.
On Thursday 03 January 2013 05:20 AM, Andrew Morton wrote:
> On Thu, 27 Dec 2012 20:29:14 +0530
> Laxman Dewangan <ldewangan@nvidia.com> wrote:
>
>> On Thursday 27 December 2012 08:26 PM, Marc Dietrich wrote:
>>> Hi Laxman,
>>>
>>> On Friday 21 December 2012 20:42:28 you wrote:
>>>
>>>> +
>>>> +	/* Set epoch start as 00:00:00:01:01:2000 */
>>>> +	rtc->epoch_start = mktime(2000, 1, 1, 0, 0, 0);
>>> any reason why you hard coded it to 2000? All boards I know use 2009, so with
>>> this patch, everyone needs to set his clock again.
>>>
>> No specific reason. If 2009 should be default then I can push patch to
>> set it as 2009.
> I'd like to get this into Linus soon so let's get it finished.  I
> assume it's merely this?

Yes, the following change is only require. I was waiting for driver to 
be avilable on linux-next before sending patch to avoid any conflict.
Thanks a lot for taking care.

Patch

--- a/drivers/rtc/rtc-tps6586x.c~rtc-add-rtc-driver-for-tps6586x-fix2
+++ a/drivers/rtc/rtc-tps6586x.c
@@ -260,8 +260,8 @@  static int tps6586x_rtc_probe(struct pla
 	rtc->dev = &pdev->dev;
 	rtc->irq = platform_get_irq(pdev, 0);
 
-	/* Set epoch start as 00:00:00:01:01:2000 */
-	rtc->epoch_start = mktime(2000, 1, 1, 0, 0, 0);
+	/* Set epoch start as 00:00:00:01:01:2009 */
+	rtc->epoch_start = mktime(2009, 1, 1, 0, 0, 0);
 
 	/* 1 kHz tick mode, enable tick counting */
 	ret = tps6586x_update(tps_dev, RTC_CTRL,