Patchwork graph-depends: add to exclusion list

login
register
mail settings
Submitter Yann E. MORIN
Date Jan. 2, 2013, 8:36 p.m.
Message ID <1357158963-3251-1-git-send-email-yann.morin.1998@free.fr>
Download mbox | patch
Permalink /patch/209144/
State Accepted
Commit d946a1af93741a7ae22ec69be865a6c14a37fcf1
Headers show

Comments

Yann E. MORIN - Jan. 2, 2013, 8:36 p.m.
Add the root-password internal target to the exclusion list.

Fixes failures like:
    Getting dependencies for [... 'target-root-passwd' ...]
    Error getting dependencies [... 'target-root-passwd' ...]

Which is easily singled out with:
    $ make target-root-passwd-show-depends
    make[1]: *** No rule to make target `target-root-passwd-show-depends'.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 support/scripts/graph-depends |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Peter Korsgaard - Jan. 2, 2013, 9 p.m.
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 Yann> Add the root-password internal target to the exclusion list.
 Yann> Fixes failures like:
 Yann>     Getting dependencies for [... 'target-root-passwd' ...]
 Yann>     Error getting dependencies [... 'target-root-passwd' ...]

 Yann> Which is easily singled out with:
 Yann>     $ make target-root-passwd-show-depends
 Yann>     make[1]: *** No rule to make target `target-root-passwd-show-depends'.

Committed, thanks.
Thomas Petazzoni - Jan. 3, 2013, 8:58 a.m.
Dear Yann E. MORIN,

On Wed,  2 Jan 2013 21:36:03 +0100, Yann E. MORIN wrote:
> Add the root-password internal target to the exclusion list.
> 
> Fixes failures like:
>     Getting dependencies for [... 'target-root-passwd' ...]
>     Error getting dependencies [... 'target-root-passwd' ...]
> 
> Which is easily singled out with:
>     $ make target-root-passwd-show-depends
>     make[1]: *** No rule to make target
> `target-root-passwd-show-depends'.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Thanks, indeed. I was in the train, and my master was not fully
up-to-date with the latest root password related changes.

Ideally, the script should parse the make output a bit better and be
capable of showing the error, but well...

Thomas

Patch

diff --git a/support/scripts/graph-depends b/support/scripts/graph-depends
index 556f11d..1163d79 100755
--- a/support/scripts/graph-depends
+++ b/support/scripts/graph-depends
@@ -167,6 +167,7 @@  TARGET_EXCEPTIONS = [
     "target-finalize",
     "erase-fakeroots",
     "target-generic-hostname",
+    "target-root-passwd",
 ]
 
 # In full mode, start with the result of get_targets() to get the main