Patchwork [5/5] ext4: Remove unnecessary wait for extent conversion in ext4_fallocate()

login
register
mail settings
Submitter Jan Kara
Date Jan. 2, 2013, 5:45 p.m.
Message ID <1357148744-4895-6-git-send-email-jack@suse.cz>
Download mbox | patch
Permalink /patch/209118/
State Superseded
Headers show

Comments

Jan Kara - Jan. 2, 2013, 5:45 p.m.
Now that we don't merge uninitialized extents anymore, ext4_fallocate()
is free to operate on the inode while there are still some extent
conversions pending - it won't disturb them in any way.

Signed-off-by: Jan Kara <jack@suse.cz>
---
 fs/ext4/extents.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
Zheng Liu - Jan. 4, 2013, 7:26 a.m.
On Wed, Jan 02, 2013 at 06:45:44PM +0100, Jan Kara wrote:
> Now that we don't merge uninitialized extents anymore, ext4_fallocate()
> is free to operate on the inode while there are still some extent
> conversions pending - it won't disturb them in any way.
> 
> Signed-off-by: Jan Kara <jack@suse.cz>

Reviewed-by: Zheng Liu <wenqing.lz@taobao.com>
Regards,
                                                - Zheng

> ---
>  fs/ext4/extents.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index f1ce33a..5c7a46a 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -4406,8 +4406,6 @@ long ext4_fallocate(struct file *file, int mode, loff_t offset, loff_t len)
>  	if (len <= EXT_UNINIT_MAX_LEN << blkbits)
>  		flags |= EXT4_GET_BLOCKS_NO_NORMALIZE;
>  
> -	/* Prevent race condition between unwritten */
> -	ext4_flush_unwritten_io(inode);
>  retry:
>  	while (ret >= 0 && ret < max_blocks) {
>  		map.m_lblk = map.m_lblk + ret;
> -- 
> 1.7.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index f1ce33a..5c7a46a 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -4406,8 +4406,6 @@  long ext4_fallocate(struct file *file, int mode, loff_t offset, loff_t len)
 	if (len <= EXT_UNINIT_MAX_LEN << blkbits)
 		flags |= EXT4_GET_BLOCKS_NO_NORMALIZE;
 
-	/* Prevent race condition between unwritten */
-	ext4_flush_unwritten_io(inode);
 retry:
 	while (ret >= 0 && ret < max_blocks) {
 		map.m_lblk = map.m_lblk + ret;