From patchwork Wed Jan 2 16:16:22 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Beno=C3=AEt_Canet?= X-Patchwork-Id: 209089 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id C1FFB2C007D for ; Thu, 3 Jan 2013 03:38:26 +1100 (EST) Received: from localhost ([::1]:33370 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqR1o-0004I8-BX for incoming@patchwork.ozlabs.org; Wed, 02 Jan 2013 11:18:52 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53627) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqR1S-0003kL-8S for qemu-devel@nongnu.org; Wed, 02 Jan 2013 11:18:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TqR1I-0006IL-Nl for qemu-devel@nongnu.org; Wed, 02 Jan 2013 11:18:30 -0500 Received: from nodalink.pck.nerim.net ([62.212.105.220]:56263 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqR1I-0006IB-2h for qemu-devel@nongnu.org; Wed, 02 Jan 2013 11:18:20 -0500 Received: by paradis.irqsave.net (Postfix, from userid 1002) id A9FCF874311; Wed, 2 Jan 2013 17:44:48 +0100 (CET) Received: from localhost.localdomain (unknown [192.168.77.1]) by paradis.irqsave.net (Postfix) with ESMTP id D0B2C874321; Wed, 2 Jan 2013 17:42:39 +0100 (CET) From: =?UTF-8?q?Beno=C3=AEt=20Canet?= To: qemu-devel@nongnu.org Date: Wed, 2 Jan 2013 17:16:22 +0100 Message-Id: <1357143393-29832-20-git-send-email-benoit@irqsave.net> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1357143393-29832-1-git-send-email-benoit@irqsave.net> References: <1357143393-29832-1-git-send-email-benoit@irqsave.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 62.212.105.220 Cc: kwolf@redhat.com, pbonzini@redhat.com, =?UTF-8?q?Beno=C3=AEt=20Canet?= , stefanha@redhat.com Subject: [Qemu-devel] [RFC V4 19/30] qcow2: Integrate deduplication in qcow2_co_writev loop. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Benoit Canet --- block/qcow2.c | 85 +++++++++++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 83 insertions(+), 2 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 9130638..54c8847 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -328,6 +328,7 @@ static int qcow2_open(BlockDriverState *bs, int flags) QCowHeader header; uint64_t ext_end; + s->has_dedup = false; ret = bdrv_pread(bs->file, 0, &header, sizeof(header)); if (ret < 0) { goto fail; @@ -790,13 +791,17 @@ static coroutine_fn int qcow2_co_writev(BlockDriverState *bs, BDRVQcowState *s = bs->opaque; int index_in_cluster; int n_end; - int ret; + int ret = 0; int cur_nr_sectors; /* number of sectors in current iteration */ uint64_t cluster_offset; QEMUIOVector hd_qiov; uint64_t bytes_done = 0; uint8_t *cluster_data = NULL; QCowL2Meta *l2meta; + uint8_t *dedup_cluster_data = NULL; + int dedup_cluster_data_nr; + int deduped_sectors_nr; + QCowDedupState ds; trace_qcow2_writev_start_req(qemu_coroutine_self(), sector_num, remaining_sectors); @@ -807,13 +812,69 @@ static coroutine_fn int qcow2_co_writev(BlockDriverState *bs, qemu_co_mutex_lock(&s->lock); + if (s->has_dedup) { + QTAILQ_INIT(&ds.undedupables); + ds.phash.reuse = false; + ds.nb_undedupable_sectors = 0; + ds.nb_clusters_processed = 0; + + /* if deduplication is on we make sure dedup_cluster_data + * contains a multiple of cluster size of data in order + * to compute the hashes + */ + ret = qcow2_dedup_read_missing_and_concatenate(bs, + qiov, + sector_num, + remaining_sectors, + &dedup_cluster_data, + &dedup_cluster_data_nr); + + if (ret < 0) { + goto fail; + } + } + while (remaining_sectors != 0) { l2meta = NULL; trace_qcow2_writev_start_part(qemu_coroutine_self()); + + if (s->has_dedup && ds.nb_undedupable_sectors == 0) { + /* Try to deduplicate as much clusters as possible */ + deduped_sectors_nr = qcow2_dedup(bs, + &ds, + sector_num, + dedup_cluster_data, + dedup_cluster_data_nr); + + if (deduped_sectors_nr < 0) { + goto fail; + } + + remaining_sectors -= deduped_sectors_nr; + sector_num += deduped_sectors_nr; + bytes_done += deduped_sectors_nr * 512; + + /* no more data to write -> exit */ + if (remaining_sectors <= 0) { + goto fail; + } + + /* if we deduped something trace it */ + if (deduped_sectors_nr) { + trace_qcow2_writev_done_part(qemu_coroutine_self(), + deduped_sectors_nr); + trace_qcow2_writev_start_part(qemu_coroutine_self()); + } + } + index_in_cluster = sector_num & (s->cluster_sectors - 1); - n_end = index_in_cluster + remaining_sectors; + n_end = s->has_dedup && + ds.nb_undedupable_sectors < remaining_sectors ? + index_in_cluster + ds.nb_undedupable_sectors : + index_in_cluster + remaining_sectors; + if (s->crypt_method && n_end > QCOW_MAX_CRYPT_CLUSTERS * s->cluster_sectors) { n_end = QCOW_MAX_CRYPT_CLUSTERS * s->cluster_sectors; @@ -849,6 +910,24 @@ static coroutine_fn int qcow2_co_writev(BlockDriverState *bs, cur_nr_sectors * 512); } + /* Write the non duplicated clusters hashes to disk */ + if (s->has_dedup) { + int count = cur_nr_sectors / s->cluster_sectors; + int has_ending = ((cluster_offset >> 9) + index_in_cluster + + cur_nr_sectors) & (s->cluster_sectors - 1); + count = index_in_cluster ? count + 1 : count; + count = has_ending ? count + 1 : count; + ret = qcow2_dedup_store_new_hashes(bs, + &ds, + count, + sector_num, + (cluster_offset >> 9)); + if (ret < 0) { + goto fail; + } + } + + BLKDBG_EVENT(bs->file, BLKDBG_WRITE_AIO); qemu_co_mutex_unlock(&s->lock); BLKDBG_EVENT(bs->file, BLKDBG_WRITE_AIO); trace_qcow2_writev_data(qemu_coroutine_self(), @@ -880,6 +959,7 @@ static coroutine_fn int qcow2_co_writev(BlockDriverState *bs, l2meta = NULL; } + ds.nb_undedupable_sectors -= cur_nr_sectors; remaining_sectors -= cur_nr_sectors; sector_num += cur_nr_sectors; bytes_done += cur_nr_sectors * 512; @@ -900,6 +980,7 @@ fail: qemu_iovec_destroy(&hd_qiov); qemu_vfree(cluster_data); + qemu_vfree(dedup_cluster_data); trace_qcow2_writev_done_req(qemu_coroutine_self(), ret); return ret;