Patchwork mac802154: fix NOHZ local_softirq_pending 08 warning

login
register
mail settings
Submitter Alexander Aring
Date Jan. 2, 2013, 11:01 a.m.
Message ID <1357124470-2375-1-git-send-email-alex.aring@gmail.com>
Download mbox | patch
Permalink /patch/208989/
State Accepted
Delegated to: David Miller
Headers show

Comments

Alexander Aring - Jan. 2, 2013, 11:01 a.m.
When using nanosleep() in an userspace application we get a
ratelimit warning

NOHZ: local_softirq_pending 08

for 10 times.

This patch replaces netif_rx() with netif_rx_ni() which has
to be used from process/softirq context.
The process/softirq context will be called from fakelb driver.

See linux-kernel commit 481a819 for similar fix.

Signed-off-by: Alexander Aring <alex.aring@gmail.com>
---
 net/mac802154/wpan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
David Miller - Jan. 4, 2013, 9:47 p.m.
From: Alexander Aring <alex.aring@googlemail.com>
Date: Wed,  2 Jan 2013 12:01:10 +0100

> When using nanosleep() in an userspace application we get a
> ratelimit warning
> 
> NOHZ: local_softirq_pending 08
> 
> for 10 times.
> 
> This patch replaces netif_rx() with netif_rx_ni() which has
> to be used from process/softirq context.
> The process/softirq context will be called from fakelb driver.
> 
> See linux-kernel commit 481a819 for similar fix.
> 
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/mac802154/wpan.c b/net/mac802154/wpan.c
index 1191039..199b922 100644
--- a/net/mac802154/wpan.c
+++ b/net/mac802154/wpan.c
@@ -389,7 +389,7 @@  void mac802154_wpan_setup(struct net_device *dev)
 
 static int mac802154_process_data(struct net_device *dev, struct sk_buff *skb)
 {
-	return netif_rx(skb);
+	return netif_rx_ni(skb);
 }
 
 static int