Patchwork [net-next,09/15] qlcnic: guard __vlan_find_dev_deep() by rcu_read_lock

login
register
mail settings
Submitter Jiri Pirko
Date Dec. 30, 2012, 11:58 a.m.
Message ID <1356868702-8144-10-git-send-email-jiri@resnulli.us>
Download mbox | patch
Permalink /patch/208745/
State Changes Requested
Delegated to: David Miller
Headers show

Comments

Jiri Pirko - Dec. 30, 2012, 11:58 a.m.
rcu_read_lock was missing here

Signed-off-by: Jiri Pirko <jiri@resnulli.us>
---
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 2 ++
 1 file changed, 2 insertions(+)

Patch

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
index d833f59..95b628f 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
@@ -2867,12 +2867,14 @@  qlcnic_restore_indev_addr(struct net_device *netdev, unsigned long event)
 
 	qlcnic_config_indev_addr(adapter, netdev, event);
 
+	rcu_read_lock();
 	for_each_set_bit(vid, adapter->vlans, VLAN_N_VID) {
 		dev = __vlan_find_dev_deep(netdev, vid);
 		if (!dev)
 			continue;
 		qlcnic_config_indev_addr(adapter, dev, event);
 	}
+	rcu_read_unlock();
 }
 
 static int qlcnic_netdev_event(struct notifier_block *this,