Patchwork [PATCHv2] wavpack: fix broken link on newer binutils

login
register
mail settings
Submitter Gustavo Zacarias
Date Dec. 29, 2012, 1:06 p.m.
Message ID <1356786371-12126-1-git-send-email-gustavo@zacarias.com.ar>
Download mbox | patch
Permalink /patch/208658/
State Accepted
Headers show

Comments

Gustavo Zacarias - Dec. 29, 2012, 1:06 p.m.
Newer versions of binutils (2.22+) default to --no-copy-dt-needed hence
all the used libraries must be explicitly named.
This is accounted for in the source configure script but not in the
compiled form so we just need to autoreconf it.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/multimedia/wavpack/wavpack.mk |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
Peter Korsgaard - Dec. 29, 2012, 1:31 p.m.
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:

 Gustavo> Newer versions of binutils (2.22+) default to
 Gustavo> --no-copy-dt-needed hence all the used libraries must be
 Gustavo> explicitly named.  This is accounted for in the source
 Gustavo> configure script but not in the compiled form so we just need
 Gustavo> to autoreconf it.

Committed with a comment explaining why autoreconf is needed, thanks.

Patch

diff --git a/package/multimedia/wavpack/wavpack.mk b/package/multimedia/wavpack/wavpack.mk
index 4b1c59e..ad1ce1b 100644
--- a/package/multimedia/wavpack/wavpack.mk
+++ b/package/multimedia/wavpack/wavpack.mk
@@ -8,9 +8,9 @@  WAVPACK_VERSION = 4.60.1
 WAVPACK_SITE = http://www.wavpack.com
 WAVPACK_SOURCE = wavpack-$(WAVPACK_VERSION).tar.bz2
 WAVPACK_INSTALL_STAGING = YES
-
-ifneq ($(BR2_ENABLE_LOCALE),y)
-WAVPACK_DEPENDENCIES += libiconv
-endif
+WAVPACK_AUTORECONF = YES
+WAVPACK_DEPENDENCIES = $(if $(BR2_ENABLE_LOCALE),libiconv)
+WAVPACK_LICENSE = BSD-3c
+WAVPACK_LICENSE_FILES = license.txt
 
 $(eval $(autotools-package))