| Submitter | stephen hemminger |
|---|---|
| Date | Dec. 29, 2012, 4:24 a.m. |
| Message ID | <20121228202428.5aa18a7b@nehalam.linuxnetplumber.net> |
| Download | mbox | patch |
| Permalink | /patch/208618/ |
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
Comments
From: Stephen Hemminger <shemminger@vyatta.com> Date: Fri, 28 Dec 2012 20:24:28 -0800 > Sparse detected case where this local function should be static. > It may even allow some compiler optimizations. > > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Patch
--- a/net/core/skbuff.c 2012-12-28 19:46:31.967615872 -0800 +++ b/net/core/skbuff.c 2012-12-28 20:00:33.343165940 -0800 @@ -155,8 +155,9 @@ static void skb_under_panic(struct sk_bu */ #define kmalloc_reserve(size, gfp, node, pfmemalloc) \ __kmalloc_reserve(size, gfp, node, _RET_IP_, pfmemalloc) -void *__kmalloc_reserve(size_t size, gfp_t flags, int node, unsigned long ip, - bool *pfmemalloc) + +static void *__kmalloc_reserve(size_t size, gfp_t flags, int node, + unsigned long ip, bool *pfmemalloc) { void *obj; bool ret_pfmemalloc = false;
Sparse detected case where this local function should be static. It may even allow some compiler optimizations. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html