Patchwork netfilter: add include file to nf_conntrack_snmp.c

login
register
mail settings
Submitter stephen hemminger
Date Dec. 29, 2012, 4:17 a.m.
Message ID <20121228201708.77f1c376@nehalam.linuxnetplumber.net>
Download mbox | patch
Permalink /patch/208615/
State Accepted
Headers show

Comments

stephen hemminger - Dec. 29, 2012, 4:17 a.m.
Prototype for nf_nat_snmp_hook is in nf_conntrack_snmp.h therefore
it should be included to get type checking. Found by sparse.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>


--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Pablo Neira - Jan. 17, 2013, 11:36 p.m.
On Fri, Dec 28, 2012 at 08:17:08PM -0800, Stephen Hemminger wrote:
> Prototype for nf_nat_snmp_hook is in nf_conntrack_snmp.h therefore
> it should be included to get type checking. Found by sparse.

Applied, thanks Stephen.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- a/net/netfilter/nf_conntrack_snmp.c	2012-10-25 09:11:15.711271681 -0700
+++ b/net/netfilter/nf_conntrack_snmp.c	2012-12-28 20:09:04.666030725 -0800
@@ -16,6 +16,7 @@ 
 #include <net/netfilter/nf_conntrack.h>
 #include <net/netfilter/nf_conntrack_helper.h>
 #include <net/netfilter/nf_conntrack_expect.h>
+#include <linux/netfilter/nf_conntrack_snmp.h>
 
 #define SNMP_PORT	161