Patchwork [pull,request,v4] Pull request for branch yem-root-passwd

login
register
mail settings
Submitter Yann E. MORIN
Date Dec. 29, 2012, 12:07 a.m.
Message ID <cover.1356739565.git.yann.morin.1998@free.fr>
Download mbox
Permalink /patch/208606/
State Not Applicable
Headers show

Pull-request

git://gitorious.org/buildroot/buildroot.git yem-root-passwd

Comments

Yann E. MORIN - Dec. 29, 2012, 12:07 a.m.
Hello All!

This is iteration #4 for setting the root password from the configuration
menu:
  - first patch adds the basic functionality:
    - plain text password in menuconfig
    - MD5-encrypted in /etc/shadow
  - second patch adds additional encryption methods

There has been previous review of this series by Arnout, who suggested
dropping patch #2, and only use an MD5-encrypted password. Since MD5 is now
considered to be a weak hash, stronger alternatives may be usefull for the
security-conscious lurking among us. That's why I kept (resurrected) that
second patch.

Arnout also objected to having the root password in clear in the .config,
and recommended that the user enters the already-encrypted password. That
has, IMHO, a few drawbacks, in that it requires the user actually reads
the help text, switch to an alternate terminal, generates a password, and
copy-pastes it back in the initial terminal with the menuconfig. OTOH, if
the user forgets his/her password, he/she can recover it by looking at the
.config file. That's why I still advocates for entering a clear-text
password in the menuconfig.

Any more comments are welcome!

Changes v3 -> v4:
  - fix the test for dependencies (Thomas)

The following changes since commit 14989d0be59762a354e7c5c15a2eeb4826d8040b:

  package/tvheadend: new package (2012-12-28 23:40:26 +0100)

are available in the git repository at:
  git://gitorious.org/buildroot/buildroot.git yem-root-passwd

Yann E. MORIN (2):
      target: add option to set the root password
      target: add different methods to encode the root password

 support/dependencies/dependencies.sh |    9 +++++
 system/Config.in                     |   67 ++++++++++++++++++++++++++++++++++
 system/system.mk                     |   15 ++++++++
 3 files changed, 91 insertions(+), 0 deletions(-)

Regards,
Yann E. MORIN