| Submitter | Jarek Poplawski |
|---|---|
| Date | Sept. 30, 2008, 11:17 a.m. |
| Message ID | <20080930111733.GB6290@ff.dom.local> |
| Download | mbox | patch |
| Permalink | /patch/2084/ |
| State | Rejected |
| Headers | show |
Comments
Jarek, Yes I am using n2kpci/8390 driver. The second patch seems to have removed the inconsistent lock state. But the kernel panic still occured systematically. However I did not catch netconsole messages since the patch prevented transmission to remote console via ethernet. Before the machine rebooted I only noted the following information at the bottom of the local console page : EIP: [<.....>] datagram_poll + 0xe9/0xf0 Does it help ? Bernard Jarek Poplawski wrote: > On Tue, Sep 30, 2008 at 10:10:30AM +0000, Jarek Poplawski wrote: >> On Tue, Sep 30, 2008 at 11:40:39AM +0200, Bernard Pidoux F6BVP wrote: >>> Hi Jarek, >> Hi Bernard, >> >>> Yes this is a vanilla kernel, which makes it interesting to debug. >>> I forgot to Cc: Ralf and put it now on copy of this message. >>> Thank you for the patch I applied. >>> Collected data includes both events I already reported, first the >>> inconsistent lock state, >> I guess this netconsole is on ne2k_pci/8390 driver? > > If so, try this patch, please. > > Jarek P. > > --- > > drivers/net/lib8390.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/lib8390.c b/drivers/net/lib8390.c > index 00d59ab..f80dcc1 100644 > --- a/drivers/net/lib8390.c > +++ b/drivers/net/lib8390.c > @@ -530,9 +530,9 @@ static irqreturn_t __ei_interrupt(int irq, void *dev_id) > #ifdef CONFIG_NET_POLL_CONTROLLER > static void __ei_poll(struct net_device *dev) > { > - disable_irq_lockdep(dev->irq); > + disable_irq(dev->irq); > __ei_interrupt(dev->irq, dev); > - enable_irq_lockdep(dev->irq); > + enable_irq(dev->irq); > } > #endif > > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Patch
diff --git a/drivers/net/lib8390.c b/drivers/net/lib8390.c index 00d59ab..f80dcc1 100644 --- a/drivers/net/lib8390.c +++ b/drivers/net/lib8390.c @@ -530,9 +530,9 @@ static irqreturn_t __ei_interrupt(int irq, void *dev_id) #ifdef CONFIG_NET_POLL_CONTROLLER static void __ei_poll(struct net_device *dev) { - disable_irq_lockdep(dev->irq); + disable_irq(dev->irq); __ei_interrupt(dev->irq, dev); - enable_irq_lockdep(dev->irq); + enable_irq(dev->irq); } #endif