[v2,1/2] rxvt-unicode: new package

Submitter	Stefan Fröberg
Date	Dec. 27, 2012, 6:45 p.m.
Message ID	<1356633918-16114-1-git-send-email-stefan.froberg@petroprogram.com>
Download	mbox \| patch
Permalink	/patch/208349/
State	Superseded
Headers	show Return-Path: <buildroot-bounces@busybox.net> sender: stefan.froberg@petroprogram.com) by mail.petroprogram.com (Postfix) with ESMTPSA id A248244316; Thu, 27 Dec 2012 20:36:12 +0200 (EET) From: =?UTF-8?q?Stefan=20Fr=C3=B6berg?= <stefan.froberg@petroprogram.com> To: buildroot@busybox.net Date: Thu, 27 Dec 2012 20:45:17 +0200 Message-Id: <1356633918-16114-1-git-send-email-stefan.froberg@petroprogram.com> MIME-Version: 1.0 Subject: [Buildroot] [PATCH v2 1/2] rxvt-unicode: new package Precedence: list Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net

Comments

Stefan Fröberg - Dec. 27, 2012, 6:45 p.m.

Signed-off-by: Stefan Fröberg <stefan.froberg@petroprogram.com>
---
 package/Config.in                    |    1 +
 package/rxvt-unicode/Config.in       |    9 +++++++++
 package/rxvt-unicode/rxvt-unicode.mk |   12 ++++++++++++
 3 files changed, 22 insertions(+), 0 deletions(-)
 create mode 100644 package/rxvt-unicode/Config.in
 create mode 100644 package/rxvt-unicode/rxvt-unicode.mk

Thomas Petazzoni - Jan. 3, 2013, 11:25 p.m.

Dear Stefan Fröberg,

On Thu, 27 Dec 2012 20:45:17 +0200, Stefan Fröberg wrote:
> Signed-off-by: Stefan Fröberg <stefan.froberg@petroprogram.com>
> ---
>  package/Config.in                    |    1 +
>  package/rxvt-unicode/Config.in       |    9 +++++++++
>  package/rxvt-unicode/rxvt-unicode.mk |   12 ++++++++++++
>  3 files changed, 22 insertions(+), 0 deletions(-)
>  create mode 100644 package/rxvt-unicode/Config.in
>  create mode 100644 package/rxvt-unicode/rxvt-unicode.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 66445ff..73bab6e 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -169,6 +169,7 @@ source "package/leafpad/Config.in"
>  source "package/midori/Config.in"
>  source "package/pcmanfm/Config.in"
>  source "package/rdesktop/Config.in"
> +source "package/rxvt-unicode/Config.in"
>  source "package/sylpheed/Config.in"
>  source "package/synergy/Config.in"
>  source "package/torsmo/Config.in"
> diff --git a/package/rxvt-unicode/Config.in b/package/rxvt-unicode/Config.in
> new file mode 100644
> index 0000000..3d819ce
> --- /dev/null
> +++ b/package/rxvt-unicode/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_RXVT_UNICODE
> +	bool "rxvt-unicode"
> +	select BR2_PACKAGE_FONTCONFIG
> +	select BR2_PACKAGE_NCURSES
> +	depends on BR2_PACKAGE_XORG7

Please add:

	select BR2_PACKAGE_XLIB_LIBX11
	select BR2_PACKAGE_XLIB_LIBXRENDER

> +	help
> +	  rxvt clone with xft and unicode support

You're saying it uses Xft, but xlib_libXft is not part of your
dependencies. Is this normal?

> --- /dev/null
> +++ b/package/rxvt-unicode/rxvt-unicode.mk
> @@ -0,0 +1,12 @@
> +#############################################################
> +#
> +# rxvt-unicode
> +#
> +#############################################################
> +RXVT_UNICODE_VERSION = 9.15
> +RXVT_UNICODE_SOURCE = rxvt-unicode-$(RXVT_UNICODE_VERSION).tar.bz2
> +RXVT_UNICODE_SITE = http://dist.schmorp.de/rxvt-unicode
> +RXVT_UNICODE_DEPENDENCIES = fontconfig ncurses xlib_libX11 xlib_libXrender
> +RXVT_UNICODE_CONF_OPT += --enable-everything --disable-perl --with-x --with-terminfo=/usr/share/terminfo

Please cut this line:

RXVT_UNICODE_CONF_OPT += \
	--enable-everything \
	--disable-perl \
	--with-x \
	--with-terminfo=/usr/share/terminfo

Also, please add the RXVT_UNICODE_LICENSE and
RXVT_UNICODE_LICENSE_FILES variables.

Thanks!

Thomas

Stefan Fröberg - Jan. 4, 2013, 2:31 p.m.

Hi Thomas

4.1.2013 1:25, Thomas Petazzoni kirjoitti:
> Dear Stefan Fröberg,
>
> On Thu, 27 Dec 2012 20:45:17 +0200, Stefan Fröberg wrote:
>> Signed-off-by: Stefan Fröberg <stefan.froberg@petroprogram.com>
>> ---
>>  package/Config.in                    |    1 +
>>  package/rxvt-unicode/Config.in       |    9 +++++++++
>>  package/rxvt-unicode/rxvt-unicode.mk |   12 ++++++++++++
>>  3 files changed, 22 insertions(+), 0 deletions(-)
>>  create mode 100644 package/rxvt-unicode/Config.in
>>  create mode 100644 package/rxvt-unicode/rxvt-unicode.mk
>>
>> diff --git a/package/Config.in b/package/Config.in
>> index 66445ff..73bab6e 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -169,6 +169,7 @@ source "package/leafpad/Config.in"
>>  source "package/midori/Config.in"
>>  source "package/pcmanfm/Config.in"
>>  source "package/rdesktop/Config.in"
>> +source "package/rxvt-unicode/Config.in"
>>  source "package/sylpheed/Config.in"
>>  source "package/synergy/Config.in"
>>  source "package/torsmo/Config.in"
>> diff --git a/package/rxvt-unicode/Config.in b/package/rxvt-unicode/Config.in
>> new file mode 100644
>> index 0000000..3d819ce
>> --- /dev/null
>> +++ b/package/rxvt-unicode/Config.in
>> @@ -0,0 +1,9 @@
>> +config BR2_PACKAGE_RXVT_UNICODE
>> +	bool "rxvt-unicode"
>> +	select BR2_PACKAGE_FONTCONFIG
>> +	select BR2_PACKAGE_NCURSES
>> +	depends on BR2_PACKAGE_XORG7
> Please add:
>
> 	select BR2_PACKAGE_XLIB_LIBX11
> 	select BR2_PACKAGE_XLIB_LIBXRENDER
>
>> +	help
>> +	  rxvt clone with xft and unicode support
> You're saying it uses Xft, but xlib_libXft is not part of your
> dependencies. Is this normal?
Ach! I forgot to add that...

>> --- /dev/null
>> +++ b/package/rxvt-unicode/rxvt-unicode.mk
>> @@ -0,0 +1,12 @@
>> +#############################################################
>> +#
>> +# rxvt-unicode
>> +#
>> +#############################################################
>> +RXVT_UNICODE_VERSION = 9.15
>> +RXVT_UNICODE_SOURCE = rxvt-unicode-$(RXVT_UNICODE_VERSION).tar.bz2
>> +RXVT_UNICODE_SITE = http://dist.schmorp.de/rxvt-unicode
>> +RXVT_UNICODE_DEPENDENCIES = fontconfig ncurses xlib_libX11 xlib_libXrender
>> +RXVT_UNICODE_CONF_OPT += --enable-everything --disable-perl --with-x --with-terminfo=/usr/share/terminfo
> Please cut this line:
>
> RXVT_UNICODE_CONF_OPT += \
> 	--enable-everything \
> 	--disable-perl \
> 	--with-x \
> 	--with-terminfo=/usr/share/terminfo
>
> Also, please add the RXVT_UNICODE_LICENSE and
> RXVT_UNICODE_LICENSE_FILES variables.

Ok, I will.

Thanks Thomas!

Stefan

> Thanks!
>
> Thomas

Patch

diff --git a/package/Config.in b/package/Config.in
index 66445ff..73bab6e 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -169,6 +169,7 @@  source "package/leafpad/Config.in"
 source "package/midori/Config.in"
 source "package/pcmanfm/Config.in"
 source "package/rdesktop/Config.in"
+source "package/rxvt-unicode/Config.in"
 source "package/sylpheed/Config.in"
 source "package/synergy/Config.in"
 source "package/torsmo/Config.in"
diff --git a/package/rxvt-unicode/Config.in b/package/rxvt-unicode/Config.in
new file mode 100644
index 0000000..3d819ce
--- /dev/null
+++ b/package/rxvt-unicode/Config.in
@@ -0,0 +1,9 @@ 
+config BR2_PACKAGE_RXVT_UNICODE
+	bool "rxvt-unicode"
+	select BR2_PACKAGE_FONTCONFIG
+	select BR2_PACKAGE_NCURSES
+	depends on BR2_PACKAGE_XORG7
+	help
+	  rxvt clone with xft and unicode support
+
+	  http://software.schmorp.de/pkg/rxvt-unicode
diff --git a/package/rxvt-unicode/rxvt-unicode.mk b/package/rxvt-unicode/rxvt-unicode.mk
new file mode 100644
index 0000000..009b40e
--- /dev/null
+++ b/package/rxvt-unicode/rxvt-unicode.mk
@@ -0,0 +1,12 @@ 
+#############################################################
+#
+# rxvt-unicode
+#
+#############################################################
+RXVT_UNICODE_VERSION = 9.15
+RXVT_UNICODE_SOURCE = rxvt-unicode-$(RXVT_UNICODE_VERSION).tar.bz2
+RXVT_UNICODE_SITE = http://dist.schmorp.de/rxvt-unicode
+RXVT_UNICODE_DEPENDENCIES = fontconfig ncurses xlib_libX11 xlib_libXrender
+RXVT_UNICODE_CONF_OPT += --enable-everything --disable-perl --with-x --with-terminfo=/usr/share/terminfo
+
+$(eval $(autotools-package))

Patchwork [v2,1/2] rxvt-unicode: new package

Comments

Patch