From patchwork Thu Dec 27 15:46:29 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [ipset] Fix wrong bracket placing From: Thomas Jarosch X-Patchwork-Id: 208331 Message-Id: <1952176.MYFl3FrgUH@storm> To: netfilter-devel@vger.kernel.org Cc: Jozsef Kadlecsik Date: Thu, 27 Dec 2012 16:46:29 +0100 cppcheck (vaguely) reported: [lib/parse.c:448]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses. Signed-off-by: Thomas Jarosch --- lib/parse.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/parse.c b/lib/parse.c index 550048c..d06e9cd 100644 --- a/lib/parse.c +++ b/lib/parse.c @@ -445,8 +445,8 @@ ipset_parse_proto(struct ipset_session *session, uint8_t protonum; int err; - if (!((err = string_to_u8(session, str, &protonum) == 0) && - (protoent = getprotobynumber(protonum)) != NULL)) + if (!((err = string_to_u8(session, str, &protonum)) == 0) && + (protoent = getprotobynumber(protonum)) != NULL) return syntax_err("cannot parse '%s' " "as a protocol", str); }