Patchwork [16/20] target-i386: set custom 'level' without intermediate x86_def_t

login
register
mail settings
Submitter Igor Mammedov
Date Dec. 27, 2012, 2:59 p.m.
Message ID <1356620376-23501-17-git-send-email-imammedo@redhat.com>
Download mbox | patch
Permalink /patch/208321/
State New
Headers show

Comments

Igor Mammedov - Dec. 27, 2012, 2:59 p.m.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
 target-i386/cpu.c |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)
Eduardo Habkost - Dec. 27, 2012, 7:32 p.m.
On Thu, Dec 27, 2012 at 03:59:32PM +0100, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>

Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>

Now I am starting to see why you are using featurestr in the qdict_put()
calls.  :-)

> ---
>  target-i386/cpu.c |    8 +-------
>  1 files changed, 1 insertions(+), 7 deletions(-)
> 
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index d8af528..1cb2f08 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1319,13 +1319,7 @@ static int cpu_x86_parse_featurestr(x86_def_t *x86_cpu_def, char *features,
>                  }
>                  x86_cpu_def->stepping = numvalue ;
>              } else if (!strcmp(featurestr, "level")) {
> -                char *err;
> -                numvalue = strtoul(val, &err, 0);
> -                if (!*val || *err) {
> -                    fprintf(stderr, "bad numerical value %s\n", val);
> -                    goto error;
> -                }
> -                x86_cpu_def->level = numvalue;
> +                qdict_put(*props, featurestr, qstring_from_str(val));
>              } else if (!strcmp(featurestr, "xlevel")) {
>                  char *err;
>                  numvalue = strtoul(val, &err, 0);
> -- 
> 1.7.1
>

Patch

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index d8af528..1cb2f08 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1319,13 +1319,7 @@  static int cpu_x86_parse_featurestr(x86_def_t *x86_cpu_def, char *features,
                 }
                 x86_cpu_def->stepping = numvalue ;
             } else if (!strcmp(featurestr, "level")) {
-                char *err;
-                numvalue = strtoul(val, &err, 0);
-                if (!*val || *err) {
-                    fprintf(stderr, "bad numerical value %s\n", val);
-                    goto error;
-                }
-                x86_cpu_def->level = numvalue;
+                qdict_put(*props, featurestr, qstring_from_str(val));
             } else if (!strcmp(featurestr, "xlevel")) {
                 char *err;
                 numvalue = strtoul(val, &err, 0);