From patchwork Thu Dec 27 14:12:30 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [libnetfilter_conntrack] Fix logic typo in cmp_secctx Date: Thu, 27 Dec 2012 04:12:30 -0000 From: Thomas Jarosch X-Patchwork-Id: 208299 Message-Id: <4631253.eD7KB7KPU6@storm> To: netfilter-devel@vger.kernel.org cppcheck reported: [src/conntrack/compare.c:364] -> [src/conntrack/compare.c:364]: (style) Same expression on both sides of '||'. Signed-off-by: Thomas Jarosch --- src/conntrack/compare.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conntrack/compare.c b/src/conntrack/compare.c index b18f7fc..e282a24 100644 --- a/src/conntrack/compare.c +++ b/src/conntrack/compare.c @@ -361,7 +361,7 @@ cmp_secctx(const struct nf_conntrack *ct1, const struct nf_conntrack *ct2, unsigned int flags) { - if (ct1->secctx == NULL || ct1->secctx == NULL) + if (ct1->secctx == NULL || ct2->secctx == NULL) return ct1->secctx == ct2->secctx; return strcmp(ct1->secctx, ct2->secctx) == 0; }