Patchwork linux-user/syscall.c: remove forward declarations

login
register
mail settings
Submitter John Spencer
Date Dec. 25, 2012, 11:49 p.m.
Message ID <1356479389-1967-1-git-send-email-maillist-qemu@barfooze.de>
Download mbox | patch
Permalink /patch/208134/
State New
Headers show

Comments

John Spencer - Dec. 25, 2012, 11:49 p.m.
instead use the correct headers that define these functions.

Requested-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: John Spencer <maillist-qemu@barfooze.de>
---
 linux-user/syscall.c |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)
Jianjun Kong - Dec. 26, 2012, 1:25 a.m.
On Wed, Dec 26, 2012 at 7:49 AM, John Spencer <maillist-qemu@barfooze.de> wrote:
>
> instead use the correct headers that define these functions.
>
> Requested-by: Stefan Weil <sw@weilnetz.de>
> Signed-off-by: John Spencer <maillist-qemu@barfooze.de>
> ---
>  linux-user/syscall.c |    8 +++-----
>  1 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index e99adab..3167a87 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -36,6 +36,9 @@
>  #include <sys/time.h>
>  #include <sys/stat.h>
>  #include <sys/mount.h>
> +#include <sys/file.h>
> +#include <sys/fsuid.h>
> +#include <sys/personality.h>
>  #include <sys/prctl.h>
>  #include <sys/resource.h>
>  #include <sys/mman.h>
> @@ -581,11 +584,6 @@ _syscall4(int, sys_prlimit64, pid_t, pid, int, resource,
>            struct host_rlimit64 *, old_limit)
>  #endif
>
> -extern int personality(int);
> -extern int flock(int, int);
> -extern int setfsuid(int);
> -extern int setfsgid(int);
> -

Reviewed-by: Amos Kong <kongjianjun@gmail.com>

>  /* ARM EABI and MIPS expect 64bit types aligned even on pairs or registers */
>  #ifdef TARGET_ARM
>  static inline int regpairs_aligned(void *cpu_env) {
> --
> 1.7.3.4
>
>
Stefan Weil - Dec. 26, 2012, 7:51 a.m.
Am 26.12.2012 00:49, schrieb John Spencer:
> instead use the correct headers that define these functions.
>
> Requested-by: Stefan Weil <sw@weilnetz.de>
> Signed-off-by: John Spencer <maillist-qemu@barfooze.de>
> ---
>   linux-user/syscall.c |    8 +++-----
>   1 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index e99adab..3167a87 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -36,6 +36,9 @@
>   #include <sys/time.h>
>   #include <sys/stat.h>
>   #include <sys/mount.h>
> +#include <sys/file.h>
> +#include <sys/fsuid.h>
> +#include <sys/personality.h>
>   #include <sys/prctl.h>
>   #include <sys/resource.h>
>   #include <sys/mman.h>
> @@ -581,11 +584,6 @@ _syscall4(int, sys_prlimit64, pid_t, pid, int, resource,
>             struct host_rlimit64 *, old_limit)
>   #endif
>   
> -extern int personality(int);
> -extern int flock(int, int);
> -extern int setfsuid(int);
> -extern int setfsgid(int);
> -
>   /* ARM EABI and MIPS expect 64bit types aligned even on pairs or registers */
>   #ifdef TARGET_ARM
>   static inline int regpairs_aligned(void *cpu_env) {

Reviewed-by: Stefan Weil <sw@weilnetz.de>
Stefan Hajnoczi - Jan. 3, 2013, 9:04 a.m.
On Wed, Dec 26, 2012 at 12:49:49AM +0100, John Spencer wrote:
> instead use the correct headers that define these functions.
> 
> Requested-by: Stefan Weil <sw@weilnetz.de>
> Signed-off-by: John Spencer <maillist-qemu@barfooze.de>
> ---
>  linux-user/syscall.c |    8 +++-----
>  1 files changed, 3 insertions(+), 5 deletions(-)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan

Patch

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index e99adab..3167a87 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -36,6 +36,9 @@ 
 #include <sys/time.h>
 #include <sys/stat.h>
 #include <sys/mount.h>
+#include <sys/file.h>
+#include <sys/fsuid.h>
+#include <sys/personality.h>
 #include <sys/prctl.h>
 #include <sys/resource.h>
 #include <sys/mman.h>
@@ -581,11 +584,6 @@  _syscall4(int, sys_prlimit64, pid_t, pid, int, resource,
           struct host_rlimit64 *, old_limit)
 #endif
 
-extern int personality(int);
-extern int flock(int, int);
-extern int setfsuid(int);
-extern int setfsgid(int);
-
 /* ARM EABI and MIPS expect 64bit types aligned even on pairs or registers */
 #ifdef TARGET_ARM
 static inline int regpairs_aligned(void *cpu_env) {