Patchwork [FIX,3.8] mtd: bcm47xxnflash: increase NFLASH_READY_RETRIES

login
register
mail settings
Submitter Rafał Miłecki
Date Dec. 24, 2012, 4:34 p.m.
Message ID <1356366869-22943-1-git-send-email-zajec5@gmail.com>
Download mbox | patch
Permalink /patch/208090/
State Accepted
Commit 5a40b5fb2bb3a4d1c20149fe47ab25409026ee2e
Headers show

Comments

Rafał Miłecki - Dec. 24, 2012, 4:34 p.m.
Recently imlemented writing support has shown that current num of
retries is too low. Writing requires longer waiting than simple reading.

Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
 drivers/mtd/nand/bcm47xxnflash/ops_bcm4706.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Artem Bityutskiy - Jan. 15, 2013, 1:12 p.m.
On Mon, 2012-12-24 at 17:34 +0100, Rafał Miłecki wrote:
> Recently imlemented writing support has shown that current num of
> retries is too low. Writing requires longer waiting than simple reading.
> 
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>

Just FYI, this patch is sitting in David's tree and will probably be merged to 3.8.
Rafał Miłecki - Feb. 4, 2013, 7:26 a.m.
2013/1/15 Artem Bityutskiy <dedekind1@gmail.com>:
> On Mon, 2012-12-24 at 17:34 +0100, Rafał Miłecki wrote:
>> Recently imlemented writing support has shown that current num of
>> retries is too low. Writing requires longer waiting than simple reading.
>>
>> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
>
> Just FYI, this patch is sitting in David's tree and will probably be merged to 3.8.

Ping?

Patch

diff --git a/drivers/mtd/nand/bcm47xxnflash/ops_bcm4706.c b/drivers/mtd/nand/bcm47xxnflash/ops_bcm4706.c
index 86c9a79..595de40 100644
--- a/drivers/mtd/nand/bcm47xxnflash/ops_bcm4706.c
+++ b/drivers/mtd/nand/bcm47xxnflash/ops_bcm4706.c
@@ -17,8 +17,8 @@ 
 #include "bcm47xxnflash.h"
 
 /* Broadcom uses 1'000'000 but it seems to be too many. Tests on WNDR4500 has
- * shown 164 retries as maxiumum. */
-#define NFLASH_READY_RETRIES		1000
+ * shown ~1000 retries as maxiumum. */
+#define NFLASH_READY_RETRIES		10000
 
 #define NFLASH_SECTOR_SIZE		512