Patchwork [4/4] rtc: tps65910: set irq flag to IRQF_EARLY_RESUME during irq request

login
register
mail settings
Submitter Laxman Dewangan
Date Dec. 24, 2012, 9:51 a.m.
Message ID <1356342687-3432-5-git-send-email-ldewangan@nvidia.com>
Download mbox | patch
Permalink /patch/208045/
State New
Headers show

Comments

Laxman Dewangan - Dec. 24, 2012, 9:51 a.m.
All interrupt get disabled during system suspend and enabled during
system resume. The enabling/disabling of interrupt happen in sequence
of interrupt registration with framework.

Therefore, in resume, the parent interrupt of this device enabled before
the RTC irq interrupt enabled. If RTC is enabled for alarm wake and if
system wake by alarm then there is interrupt pending for RTC. In resume,
the parent interrupt get enabled before the rtc interrupt and hence ISR
get served. In ISR, it founds that rtc interrupt is disabled and so it does
not call the rtc isr handler and hence it misses the interrupt.

Setting flag for early resume so that rtc interrupt get enabled before
parent interrupt  and so rtc interrupt get enabled when parent interrupt
handler check for interrupt of device and call the rtc handler if it is there.
This way it will not miss the interrupt.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
 drivers/rtc/rtc-tps65910.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch

diff --git a/drivers/rtc/rtc-tps65910.c b/drivers/rtc/rtc-tps65910.c
index ff98e18..d2e1c08 100644
--- a/drivers/rtc/rtc-tps65910.c
+++ b/drivers/rtc/rtc-tps65910.c
@@ -267,7 +267,7 @@  static int __devinit tps65910_rtc_probe(struct platform_device *pdev)
 	}
 
 	ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
-		tps65910_rtc_interrupt, IRQF_TRIGGER_LOW,
+		tps65910_rtc_interrupt, IRQF_TRIGGER_LOW | IRQF_EARLY_RESUME,
 		dev_name(&pdev->dev), &pdev->dev);
 	if (ret < 0) {
 		dev_err(&pdev->dev, "IRQ is not free.\n");