Message ID | CAOWBBJxB8rzAUNJNap5sLQppA68wcBByKZeE=hQK0a267zuQ7Q@mail.gmail.com |
---|---|
State | Superseded |
Headers | show |
Mikhail, All, On Sunday 23 December 2012 Mikhail Boiko wrote: > --- You need to add a Signed-off-by line, like: Signed-off-by: Your Real NAME <your.mail@adress> Please see Documentation/SubmittingPatches in the kernel source tree for the reasons and meaning of the SoB line. [--SNIP--] > diff --git a/package/libfribidi/Config.in b/package/libfribidi/Config.in > new file mode 100644 > index 0000000..11aed62 > --- /dev/null > +++ b/package/libfribidi/Config.in > @@ -0,0 +1,7 @@ > +config BR2_PACKAGE_LIBFRIBIDI > + bool "libfribidi" > + help > + GNU FriBidi is an implementation of the Unicode > + Bidirectional Algorithm (bidi). > + > + http://www.fribidi.org/ config BR2_PACKAGE_LIBFRIBIDI <TAB>bool "libfribidi" <TAB>help <TAB> GNU fribidi... That is, one TAB before keywords, and one TAB and two spaces before the hepl text. > diff --git a/package/libfribidi/libfribidi.mk b/package/libfribidi/ > libfribidi.mk > new file mode 100644 > index 0000000..5cd1bc9 > --- /dev/null > +++ b/package/libfribidi/libfribidi.mk > @@ -0,0 +1,14 @@ > +############################################################# > +# > +# libfribidi > +# > +############################################################# > + > +LIBFRIBIDI_VERSION = 0.19.5 > +LIBFRIBIDI_SOURCE = fribidi-$(LIBFRIBIDI_VERSION).tar.bz2 > +LIBFRIBIDI_SITE = http://www.fribidi.org/download/ > +LIBFRIBIDI_INSTALL_STAGING = YES > +LIBFRIBIDI_CONF_OPT = --disable-docs --disable-docs is already passed by the autotools-package infrastructure, so is not needed. > +LIBFRIBIDI_DEPENDENCIES = host-pkgconf > + > +$(eval $(autotools-package)) Regards, Yann E. MORIN.
Mikhail, All, On Sun, Dec 23, 2012 at 10:49 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > Mikhail, All, > > On Sunday 23 December 2012 Mikhail Boiko wrote: >> --- > > You need to add a Signed-off-by line, like: > Signed-off-by: Your Real NAME <your.mail@adress> > > Please see Documentation/SubmittingPatches in the kernel source tree > for the reasons and meaning of the SoB line. > > [--SNIP--] >> diff --git a/package/libfribidi/Config.in b/package/libfribidi/Config.in >> new file mode 100644 >> index 0000000..11aed62 >> --- /dev/null >> +++ b/package/libfribidi/Config.in >> @@ -0,0 +1,7 @@ >> +config BR2_PACKAGE_LIBFRIBIDI >> + bool "libfribidi" >> + help >> + GNU FriBidi is an implementation of the Unicode >> + Bidirectional Algorithm (bidi). >> + >> + http://www.fribidi.org/ > > config BR2_PACKAGE_LIBFRIBIDI > <TAB>bool "libfribidi" > <TAB>help > <TAB> GNU fribidi... > > That is, one TAB before keywords, and one TAB and two spaces before the > hepl text. > >> diff --git a/package/libfribidi/libfribidi.mk b/package/libfribidi/ >> libfribidi.mk >> new file mode 100644 >> index 0000000..5cd1bc9 >> --- /dev/null >> +++ b/package/libfribidi/libfribidi.mk >> @@ -0,0 +1,14 @@ >> +############################################################# >> +# >> +# libfribidi >> +# >> +############################################################# >> + >> +LIBFRIBIDI_VERSION = 0.19.5 >> +LIBFRIBIDI_SOURCE = fribidi-$(LIBFRIBIDI_VERSION).tar.bz2 >> +LIBFRIBIDI_SITE = http://www.fribidi.org/download/ >> +LIBFRIBIDI_INSTALL_STAGING = YES >> +LIBFRIBIDI_CONF_OPT = --disable-docs Don't forget to add the LICENCE, I assume these are correct for fribidi : FRIBIDI_LICENSE = GPLv2+ FRIBIDI_LICENSE_FILES = COPYING > > --disable-docs is already passed by the autotools-package infrastructure, > so is not needed. > >> +LIBFRIBIDI_DEPENDENCIES = host-pkgconf >> + >> +$(eval $(autotools-package)) > > Regards, > Yann E. MORIN. > > -- > .-----------------.--------------------.------------------.--------------------. > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | > | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | > '------------------------------^-------^------------------^--------------------' > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
>>>>> "Mikhail" == Mikhail Boiko <mikhailboiko85@gmail.com> writes:
Mikhail> ---
Mikhail> package/Config.in | 1 +
Mikhail> package/libfribidi/Config.in | 7 +++++++
Mikhail> package/libfribidi/libfribidi.mk | 14 ++++++++++++++
Mikhail> 3 files changed, 22 insertions(+)
Mikhail> create mode 100644 package/libfribidi/Config.in
Mikhail> create mode 100644 package/libfribidi/libfribidi.mk
Mikhail> diff --git a/package/Config.in b/package/Config.in
Mikhail> index 5d9783a..4d45577 100644
Mikhail> --- a/package/Config.in
Mikhail> +++ b/package/Config.in
Mikhail> @@ -496,6 +496,7 @@ source "package/libelf/Config.in"
Mikhail> source "package/libevent/Config.in"
Mikhail> source "package/libev/Config.in"
Mikhail> source "package/libffi/Config.in"
Mikhail> +source "package/libfribidi/Config.in"
Mikhail> source "package/gsl/Config.in"
Mikhail> source "package/libglib2/Config.in"
Mikhail> source "package/libical/Config.in"
Mikhail> diff --git a/package/libfribidi/Config.in b/package/libfribidi/Config.in
Mikhail> new file mode 100644
Mikhail> index 0000000..11aed62
Mikhail> --- /dev/null
Mikhail> +++ b/package/libfribidi/Config.in
Mikhail> @@ -0,0 +1,7 @@
Mikhail> +config BR2_PACKAGE_LIBFRIBIDI
Mikhail> + bool "libfribidi"
Mikhail> + help
Mikhail> + GNU FriBidi is an implementation of the Unicode
Trailing space.
Are you sure it doesn't depend on any toolchain features? I would have
expected it to atleast need wchar support.
Care to resend with this fixed and the other things mentioned?
(signed-off-by and license info).
diff --git a/package/Config.in b/package/Config.in index 5d9783a..4d45577 100644 --- a/package/Config.in +++ b/package/Config.in @@ -496,6 +496,7 @@ source "package/libelf/Config.in" source "package/libevent/Config.in" source "package/libev/Config.in" source "package/libffi/Config.in" +source "package/libfribidi/Config.in" source "package/gsl/Config.in" source "package/libglib2/Config.in" source "package/libical/Config.in" diff --git a/package/libfribidi/Config.in b/package/libfribidi/Config.in new file mode 100644 index 0000000..11aed62 --- /dev/null +++ b/package/libfribidi/Config.in @@ -0,0 +1,7 @@ +config BR2_PACKAGE_LIBFRIBIDI + bool "libfribidi" + help + GNU FriBidi is an implementation of the Unicode + Bidirectional Algorithm (bidi). + + http://www.fribidi.org/ diff --git a/package/libfribidi/libfribidi.mk b/package/libfribidi/ libfribidi.mk new file mode 100644 index 0000000..5cd1bc9 --- /dev/null +++ b/package/libfribidi/libfribidi.mk @@ -0,0 +1,14 @@ +############################################################# +# +# libfribidi +# +############################################################# + +LIBFRIBIDI_VERSION = 0.19.5 +LIBFRIBIDI_SOURCE = fribidi-$(LIBFRIBIDI_VERSION).tar.bz2 +LIBFRIBIDI_SITE = http://www.fribidi.org/download/ +LIBFRIBIDI_INSTALL_STAGING = YES +LIBFRIBIDI_CONF_OPT = --disable-docs +LIBFRIBIDI_DEPENDENCIES = host-pkgconf + +$(eval $(autotools-package))