| Message ID | ad26ca328f0eba6a722d0288ac1c37ad55789447.1356204860.git.richardcochran@gmail.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
Hello. On 22-12-2012 23:41, Richard Cochran wrote: > This patch fixes a warning in clk_enable by calling clk_prepare first. > Signed-off-by: Richard Cochran <richardcochran@gmail.com> > --- > drivers/net/ethernet/ti/cpts.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c > index 5ab8fb4..3e32a31 100644 > --- a/drivers/net/ethernet/ti/cpts.c > +++ b/drivers/net/ethernet/ti/cpts.c > @@ -247,6 +247,7 @@ static void cpts_clk_init(struct cpts *cpts) > cpts->refclk = NULL; > return; > } > + clk_prepare(cpts->refclk); > clk_enable(cpts->refclk); Maybe just call clk_prepare_enable() instead? WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, Dec 23, 2012 at 06:07:22PM +0400, Sergei Shtylyov wrote: > Hello. > > On 22-12-2012 23:41, Richard Cochran wrote: > > >This patch fixes a warning in clk_enable by calling clk_prepare first. > > >Signed-off-by: Richard Cochran <richardcochran@gmail.com> > >--- > > drivers/net/ethernet/ti/cpts.c | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > >diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c > >index 5ab8fb4..3e32a31 100644 > >--- a/drivers/net/ethernet/ti/cpts.c > >+++ b/drivers/net/ethernet/ti/cpts.c > >@@ -247,6 +247,7 @@ static void cpts_clk_init(struct cpts *cpts) > > cpts->refclk = NULL; > > return; > > } > >+ clk_prepare(cpts->refclk); > > clk_enable(cpts->refclk); > > Maybe just call clk_prepare_enable() instead? Okay, will fix in v2. Thanks, Richard -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c index 5ab8fb4..3e32a31 100644 --- a/drivers/net/ethernet/ti/cpts.c +++ b/drivers/net/ethernet/ti/cpts.c @@ -247,6 +247,7 @@ static void cpts_clk_init(struct cpts *cpts) cpts->refclk = NULL; return; } + clk_prepare(cpts->refclk); clk_enable(cpts->refclk); }
This patch fixes a warning in clk_enable by calling clk_prepare first. Signed-off-by: Richard Cochran <richardcochran@gmail.com> --- drivers/net/ethernet/ti/cpts.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)