Patchwork [07/15] openpic: make ctpr signed

login
register
mail settings
Submitter Scott Wood
Date Dec. 22, 2012, 2:15 a.m.
Message ID <1356142552-13453-8-git-send-email-scottwood@freescale.com>
Download mbox | patch
Permalink /patch/207914/
State New
Headers show

Comments

Scott Wood - Dec. 22, 2012, 2:15 a.m.
Other priorities are signed, so avoid comparisons between
signed and unsigned.

Signed-off-by: Scott Wood <scottwood@freescale.com>
---
 hw/openpic.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Alexander Graf - Jan. 3, 2013, 6:33 p.m.
On 22.12.2012, at 03:15, Scott Wood wrote:

> Other priorities are signed, so avoid comparisons between
> signed and unsigned.
> 
> Signed-off-by: Scott Wood <scottwood@freescale.com>

Thanks, applied to ppc-next.


Alex

Patch

diff --git a/hw/openpic.c b/hw/openpic.c
index 94a7807..9d22e9c 100644
--- a/hw/openpic.c
+++ b/hw/openpic.c
@@ -216,7 +216,7 @@  typedef struct IRQ_src_t {
 #define IDR_CI      0x40000000  /* critical interrupt */
 
 typedef struct IRQ_dst_t {
-    uint32_t ctpr; /* CPU current task priority */
+    int32_t ctpr; /* CPU current task priority */
     IRQ_queue_t raised;
     IRQ_queue_t servicing;
     qemu_irq *irqs;
@@ -1170,7 +1170,7 @@  static void openpic_save(QEMUFile* f, void *opaque)
     qemu_put_be32s(f, &opp->nb_cpus);
 
     for (i = 0; i < opp->nb_cpus; i++) {
-        qemu_put_be32s(f, &opp->dst[i].ctpr);
+        qemu_put_sbe32s(f, &opp->dst[i].ctpr);
         openpic_save_IRQ_queue(f, &opp->dst[i].raised);
         openpic_save_IRQ_queue(f, &opp->dst[i].servicing);
     }
@@ -1216,7 +1216,7 @@  static int openpic_load(QEMUFile* f, void *opaque, int version_id)
     qemu_get_be32s(f, &opp->nb_cpus);
 
     for (i = 0; i < opp->nb_cpus; i++) {
-        qemu_get_be32s(f, &opp->dst[i].ctpr);
+        qemu_get_sbe32s(f, &opp->dst[i].ctpr);
         openpic_load_IRQ_queue(f, &opp->dst[i].raised);
         openpic_load_IRQ_queue(f, &opp->dst[i].servicing);
     }