Patchwork [2/6] polkit: new package

login
register
mail settings
Submitter Marek Belisko
Date Dec. 21, 2012, 9:51 p.m.
Message ID <1356126670-16186-3-git-send-email-marek.belisko@open-nandra.com>
Download mbox | patch
Permalink /patch/207888/
State Superseded
Headers show

Comments

Marek Belisko - Dec. 21, 2012, 9:51 p.m.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Marek Belisko <marek.belisko@streamunlimited.com>
---
 package/Config.in        |    1 +
 package/polkit/Config.in |    8 ++++++++
 package/polkit/polkit.mk |   18 ++++++++++++++++++
 3 files changed, 27 insertions(+)
 create mode 100644 package/polkit/Config.in
 create mode 100644 package/polkit/polkit.mk
Thomas Petazzoni - Dec. 22, 2012, 3:18 p.m.
Dear Marek Belisko,

On Fri, 21 Dec 2012 22:51:06 +0100, Marek Belisko wrote:
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Marek Belisko <marek.belisko@streamunlimited.com>
> ---
>  package/Config.in        |    1 +
>  package/polkit/Config.in |    8 ++++++++
>  package/polkit/polkit.mk |   18 ++++++++++++++++++
>  3 files changed, 27 insertions(+)
>  create mode 100644 package/polkit/Config.in
>  create mode 100644 package/polkit/polkit.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index afecb8e..155a429 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -749,6 +749,7 @@ if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
>  source "package/module-init-tools/Config.in"
>  endif
>  source "package/monit/Config.in"
> +source "package/polkit/Config.in"
>  if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
>  source "package/procps/Config.in"
>  source "package/psmisc/Config.in"
> diff --git a/package/polkit/Config.in b/package/polkit/Config.in
> new file mode 100644
> index 0000000..9ca347a
> --- /dev/null
> +++ b/package/polkit/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_POLKIT
> +        bool "polkit"

Should be a tab, not spaces.

> +	select BR2_PACKAGE_LIBGLIB2
> +	select BR2_DBUS_EXPAT
> +	help
> +	  PolicyKit is a toolkit for defining and handling
> +	  authorizations.  It is used for allowing unprivileged
> +	  processes to speak to privileged processes.

Upstream URL missing.

> diff --git a/package/polkit/polkit.mk b/package/polkit/polkit.mk
> new file mode 100644
> index 0000000..8c882f2
> --- /dev/null
> +++ b/package/polkit/polkit.mk
> @@ -0,0 +1,18 @@
> +#############################################################
> +#
> +# polkit
> +#
> +#############################################################
> +POLKIT_VERSION = 0.103
> +POLKIT_SITE = http://www.freedesktop.org/software/polkit/releases/
> +
> +POLKIT_INSTALL_STAGING = YES

I don't remember, does polkit installs some libraries or .pc files, or
something that justify its installation in staging ?

> +POLKIT_DEPENDENCIES = libglib2 host-intltool expat
> +
> +# We could also support --with-authfw=pam
> +POLKIT_CONF_OPT = \
> +	--with-authfw=shadow \
> +	--with-os-type=unknown
> +
> +$(eval $(autotools-package))

Thanks,

Thomas
Thomas Petazzoni - Dec. 22, 2012, 3:19 p.m.
Dear Marek Belisko,

On Fri, 21 Dec 2012 22:51:06 +0100, Marek Belisko wrote:

> +	select BR2_PACKAGE_LIBGLIB2
> +	select BR2_DBUS_EXPAT

Are you sure this shouldn't be BR2_PACKAGE_EXPAT instead?

Thanks,

Thomas
Belisko Marek - Dec. 22, 2012, 9:54 p.m.
Hi Thomas,

On Sat, Dec 22, 2012 at 4:18 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Marek Belisko,
>
> On Fri, 21 Dec 2012 22:51:06 +0100, Marek Belisko wrote:
>> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>> Signed-off-by: Marek Belisko <marek.belisko@streamunlimited.com>
>> ---
>>  package/Config.in        |    1 +
>>  package/polkit/Config.in |    8 ++++++++
>>  package/polkit/polkit.mk |   18 ++++++++++++++++++
>>  3 files changed, 27 insertions(+)
>>  create mode 100644 package/polkit/Config.in
>>  create mode 100644 package/polkit/polkit.mk
>>
>> diff --git a/package/Config.in b/package/Config.in
>> index afecb8e..155a429 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -749,6 +749,7 @@ if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
>>  source "package/module-init-tools/Config.in"
>>  endif
>>  source "package/monit/Config.in"
>> +source "package/polkit/Config.in"
>>  if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
>>  source "package/procps/Config.in"
>>  source "package/psmisc/Config.in"
>> diff --git a/package/polkit/Config.in b/package/polkit/Config.in
>> new file mode 100644
>> index 0000000..9ca347a
>> --- /dev/null
>> +++ b/package/polkit/Config.in
>> @@ -0,0 +1,8 @@
>> +config BR2_PACKAGE_POLKIT
>> +        bool "polkit"
>
> Should be a tab, not spaces.
>
>> +     select BR2_PACKAGE_LIBGLIB2
>> +     select BR2_DBUS_EXPAT
>> +     help
>> +       PolicyKit is a toolkit for defining and handling
>> +       authorizations.  It is used for allowing unprivileged
>> +       processes to speak to privileged processes.
>
> Upstream URL missing.
>
>> diff --git a/package/polkit/polkit.mk b/package/polkit/polkit.mk
>> new file mode 100644
>> index 0000000..8c882f2
>> --- /dev/null
>> +++ b/package/polkit/polkit.mk
>> @@ -0,0 +1,18 @@
>> +#############################################################
>> +#
>> +# polkit
>> +#
>> +#############################################################
>> +POLKIT_VERSION = 0.103
>> +POLKIT_SITE = http://www.freedesktop.org/software/polkit/releases/
>> +
>> +POLKIT_INSTALL_STAGING = YES
>
> I don't remember, does polkit installs some libraries or .pc files, or
> something that justify its installation in staging ?
Yes. In staging there are added 3 libraries with polkit-agent-1.pc
polkit-backend-1.pc polkit-gobject-1.pc files.
>
>> +POLKIT_DEPENDENCIES = libglib2 host-intltool expat
>> +
>> +# We could also support --with-authfw=pam
>> +POLKIT_CONF_OPT = \
>> +     --with-authfw=shadow \
>> +     --with-os-type=unknown
>> +
>> +$(eval $(autotools-package))
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com

Thanks,

mbe
Belisko Marek - Dec. 22, 2012, 10:10 p.m.
Hi Thomas,

On Sat, Dec 22, 2012 at 4:19 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Marek Belisko,
>
> On Fri, 21 Dec 2012 22:51:06 +0100, Marek Belisko wrote:
>
>> +     select BR2_PACKAGE_LIBGLIB2
>> +     select BR2_DBUS_EXPAT
>
> Are you sure this shouldn't be BR2_PACKAGE_EXPAT instead?
Good catch. Thanks.
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com

Cheers,

mbe
Thomas Petazzoni - Dec. 22, 2012, 11:27 p.m.
Dear Belisko Marek,

On Sat, 22 Dec 2012 22:54:03 +0100, Belisko Marek wrote:

> >> +POLKIT_INSTALL_STAGING = YES
> >
> > I don't remember, does polkit installs some libraries or .pc files, or
> > something that justify its installation in staging ?
> Yes. In staging there are added 3 libraries with polkit-agent-1.pc
> polkit-backend-1.pc polkit-gobject-1.pc files.

Ok, thanks!

Thomas

Patch

diff --git a/package/Config.in b/package/Config.in
index afecb8e..155a429 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -749,6 +749,7 @@  if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 source "package/module-init-tools/Config.in"
 endif
 source "package/monit/Config.in"
+source "package/polkit/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 source "package/procps/Config.in"
 source "package/psmisc/Config.in"
diff --git a/package/polkit/Config.in b/package/polkit/Config.in
new file mode 100644
index 0000000..9ca347a
--- /dev/null
+++ b/package/polkit/Config.in
@@ -0,0 +1,8 @@ 
+config BR2_PACKAGE_POLKIT
+        bool "polkit"
+	select BR2_PACKAGE_LIBGLIB2
+	select BR2_DBUS_EXPAT
+	help
+	  PolicyKit is a toolkit for defining and handling
+	  authorizations.  It is used for allowing unprivileged
+	  processes to speak to privileged processes.
diff --git a/package/polkit/polkit.mk b/package/polkit/polkit.mk
new file mode 100644
index 0000000..8c882f2
--- /dev/null
+++ b/package/polkit/polkit.mk
@@ -0,0 +1,18 @@ 
+#############################################################
+#
+# polkit
+#
+#############################################################
+POLKIT_VERSION = 0.103
+POLKIT_SITE = http://www.freedesktop.org/software/polkit/releases/
+
+POLKIT_INSTALL_STAGING = YES
+
+POLKIT_DEPENDENCIES = libglib2 host-intltool expat
+
+# We could also support --with-authfw=pam
+POLKIT_CONF_OPT = \
+	--with-authfw=shadow \
+	--with-os-type=unknown
+
+$(eval $(autotools-package))