Patchwork [v2,2/2] Makefile: use toolchain target in the world target

login
register
mail settings
Submitter Fabio Porcedda
Date Dec. 21, 2012, 10:36 a.m.
Message ID <1356086190-906-3-git-send-email-fabio.porcedda@gmail.com>
Download mbox | patch
Permalink /patch/207783/
State Superseded
Headers show

Comments

Fabio Porcedda - Dec. 21, 2012, 10:36 a.m.
This is to remove redundancy and simplify the rule.

Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Markos Chandras - Dec. 21, 2012, 11:57 a.m.
On 21 December 2012 10:36, Fabio Porcedda <fabio.porcedda@gmail.com> wrote:
> This is to remove redundancy and simplify the rule.
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 458b8c5..296917e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -379,7 +379,7 @@ prepare: $(BUILD_DIR)/buildroot-config/auto.conf
>
>  toolchain: prepare dirs dependencies $(BASE_TARGETS)
>
> -world: prepare dirs dependencies $(BASE_TARGETS) $(TARGETS_ALL)
> +world: toolchain $(TARGETS_ALL)
>
>  .PHONY: all world toolchain dirs clean distclean source outputmakefile \
>         legal-info legal-info-prepare legal-info-clean \
> --
> 1.8.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

Looks good to me

Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
Arnout Vandecappelle - Dec. 21, 2012, 12:43 p.m.
On 21/12/12 11:36, Fabio Porcedda wrote:
> This is to remove redundancy and simplify the rule.
>
> Signed-off-by: Fabio Porcedda<fabio.porcedda@gmail.com>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
  (untested but trivial enough)

  Regards,
  Arnout

> ---
>   Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 458b8c5..296917e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -379,7 +379,7 @@ prepare: $(BUILD_DIR)/buildroot-config/auto.conf
>
>   toolchain: prepare dirs dependencies $(BASE_TARGETS)
>
> -world: prepare dirs dependencies $(BASE_TARGETS) $(TARGETS_ALL)
> +world: toolchain $(TARGETS_ALL)
>
>   .PHONY: all world toolchain dirs clean distclean source outputmakefile \
>   	legal-info legal-info-prepare legal-info-clean \

Patch

diff --git a/Makefile b/Makefile
index 458b8c5..296917e 100644
--- a/Makefile
+++ b/Makefile
@@ -379,7 +379,7 @@  prepare: $(BUILD_DIR)/buildroot-config/auto.conf
 
 toolchain: prepare dirs dependencies $(BASE_TARGETS)
 
-world: prepare dirs dependencies $(BASE_TARGETS) $(TARGETS_ALL)
+world: toolchain $(TARGETS_ALL)
 
 .PHONY: all world toolchain dirs clean distclean source outputmakefile \
 	legal-info legal-info-prepare legal-info-clean \