From patchwork Thu Dec 20 15:58:53 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 207680 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 199462C0089 for ; Fri, 21 Dec 2012 02:59:19 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1356623960; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:From:To:CC:Subject:In-Reply-To:References:User-Agent: Date:Message-ID:MIME-Version:Content-Type:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=EyPGz2n8OuaOEAIJfLboi8nRszw=; b=jTGQx/BQYuOrPis4eAWCESdg5Y+6C2YGLyYEAtBHDVx5yC/EfEnQKPMhk+MSus 8vPIdG/WAWivPRjH0SR4pDfJYe1q7/1j9AucCpqllifO1bf0Z26LuELpQHOkes+G pk0BJDgCyiyFgWUPJqSbpxwIQqZwtEgvBL652ATDnHq1o= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:From:To:CC:Subject:In-Reply-To:References:User-Agent:Date:Message-ID:MIME-Version:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=l1TaAJ8iIUoCqfgpOzAiFNsNvLF6QKQqXc6ka89b+4qQjAog75P6wYxxjc2qCI 9VwvlywU69VLPWhk+PFYLKR6dnnMIqBqBnjiHSFsBqrYJZyXKK5fr/yDmr+OFEIr 6Te9Thxnb/CAnA2UH+FPHRNUyZcrFCWDPn/DK1TXzd/Hg=; Received: (qmail 20329 invoked by alias); 20 Dec 2012 15:59:14 -0000 Received: (qmail 20321 invoked by uid 22791); 20 Dec 2012 15:59:13 -0000 X-SWARE-Spam-Status: No, hits=-7.7 required=5.0 tests=AWL, BAYES_00, KHOP_PGP_SIGNED, KHOP_RCVD_UNTRUST, KHOP_THREADED, RCVD_IN_HOSTKARMA_W, RCVD_IN_HOSTKARMA_WL, TW_XL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 20 Dec 2012 15:59:04 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1TliWT-0002Xv-NO from Thomas_Schwinge@mentor.com ; Thu, 20 Dec 2012 07:59:01 -0800 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 20 Dec 2012 07:59:01 -0800 Received: from feldtkeller.schwinge.homeip.net (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Thu, 20 Dec 2012 15:59:00 +0000 From: Thomas Schwinge To: Andrew Pinski CC: GCC Patches , Paolo Bonzini Subject: Re: [PATCH] Fix combined tree for LTO In-Reply-To: References: <509E68C0.9020408@gnu.org> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/23.4.1 (i486-pc-linux-gnu) Date: Thu, 20 Dec 2012 16:58:53 +0100 Message-ID: <87y5gspveq.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hi! On Sat, 10 Nov 2012 10:32:07 -0800, Andrew Pinski wrote: > 2012-11-10 Andrew Pinski > > PR bootstrap/55202 > * configure.ac: Set PLUGIN_LD_SUFFIX to just "ld" if it was "ld-new" > or "collect-ld". > * configure: Regenerate. > Index: configure.ac > =================================================================== > --- configure.ac (revision 193392) > +++ configure.ac (working copy) > @@ -2003,6 +2003,12 @@ fi]) > > ORIGINAL_PLUGIN_LD_FOR_TARGET=$gcc_cv_ld > PLUGIN_LD_SUFFIX=`basename $gcc_cv_ld | sed -e "s,$target_alias-,,"` > +# if the PLUGIN_LD is set ld-new, just have it as ld > +# as that is the installed named. > +if test x$PLUGIN_LD_SUFFIX == xld-new \ > + || test x$PLUGIN_LD_SUFFIX == xcollect-ld ; then > + PLUGIN_LD_SUFFIX=ld > +fi Using dash, this caused: checking for ld... /usr/bin/ld [...]/gcc/configure: 21384: test: xld: unexpected operator [...]/gcc/configure: 21385: test: xld: unexpected operator checking whether we are using gold... no Fixed in r194637: PR bootstrap/55202 * configure.ac : Use POSIX shell syntax. * configure: Regenerate. Grüße, Thomas diff --git gcc/configure.ac gcc/configure.ac index c6f57bd..7abe7cf 100644 --- gcc/configure.ac +++ gcc/configure.ac @@ -2031,8 +2031,8 @@ ORIGINAL_PLUGIN_LD_FOR_TARGET=$gcc_cv_ld PLUGIN_LD_SUFFIX=`basename $gcc_cv_ld | sed -e "s,$target_alias-,,"` # if the PLUGIN_LD is set ld-new, just have it as ld # as that is the installed named. -if test x$PLUGIN_LD_SUFFIX == xld-new \ - || test x$PLUGIN_LD_SUFFIX == xcollect-ld ; then +if test x$PLUGIN_LD_SUFFIX = xld-new \ + || test x$PLUGIN_LD_SUFFIX = xcollect-ld ; then PLUGIN_LD_SUFFIX=ld fi AC_ARG_WITH(plugin-ld,