Patchwork solos-pci: double lock in geos_gpio_store()

login
register
mail settings
Submitter Dan Carpenter
Date Dec. 20, 2012, 7:48 a.m.
Message ID <20121220074845.GA14716@elgon.mountain>
Download mbox | patch
Permalink /patch/207618/
State Accepted
Delegated to: David Miller
Headers show

Comments

Dan Carpenter - Dec. 20, 2012, 7:48 a.m.
There is a typo here so we do a double lock instead of an unlock.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Only needed in linux-next.  Introduced in f9baad02e7411d9 [14/17]
solos-pci: add GPIO support for newer versions on Geos board

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Woodhouse - Dec. 20, 2012, 9:22 a.m.
On Thu, 2012-12-20 at 10:48 +0300, Dan Carpenter wrote:
> There is a typo here so we do a double lock instead of an unlock.

> 

> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

> ---

> Only needed in linux-next.  Introduced in f9baad02e7411d9 [14/17]

> solos-pci: add GPIO support for newer versions on Geos board


Ah, crap. That was my fault; it was part of my "improvement" to Nathan's
patch. Sorry.

Acked-by: David Woodhouse <David.Woodhouse@intel.com>
David Miller - Dec. 21, 2012, 9:16 p.m.
From: "Woodhouse, David" <david.woodhouse@intel.com>
Date: Thu, 20 Dec 2012 09:22:26 +0000

> On Thu, 2012-12-20 at 10:48 +0300, Dan Carpenter wrote:
>> There is a typo here so we do a double lock instead of an unlock.
>> 
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>> ---
>> Only needed in linux-next.  Introduced in f9baad02e7411d9 [14/17]
>> solos-pci: add GPIO support for newer versions on Geos board
> 
> Ah, crap. That was my fault; it was part of my "improvement" to Nathan's
> patch. Sorry.
> 
> Acked-by: David Woodhouse <David.Woodhouse@intel.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
index 473d808..7b95736 100644
--- a/drivers/atm/solos-pci.c
+++ b/drivers/atm/solos-pci.c
@@ -531,7 +531,7 @@  static ssize_t geos_gpio_store(struct device *dev, struct device_attribute *attr
 	} else {
 		count = -EINVAL;
 	}
-	spin_lock_irq(&card->param_queue_lock);
+	spin_unlock_irq(&card->param_queue_lock);
 	return count;
 }