From patchwork Thu Dec 20 01:22:22 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rong Xu X-Patchwork-Id: 207583 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id F06232C0094 for ; Thu, 20 Dec 2012 12:22:39 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1356571360; h=Comment: DomainKey-Signature:Received:Received:Received:Received: MIME-Version:Received:Received:In-Reply-To:References:Date: Message-ID:Subject:From:To:Content-Type:Mailing-List:Precedence: List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=DznWC6j97v23ietWca1GzRk1ilc=; b=w3X8rBZ+u9uaa2Y 7TGE3Q6nJMc0JmXTwP8a3BgVwOfLrjz7+uzyI8mvvwIo8VzuaSQyvs3OQrCJEEpu N66LblIJDteGDGKHOxc8cVeo+4KoQlzE8lGa5JStYdB3NR7Xv64ogOBbTEZuPm9X 1rxcp3dlJ6KiFsNEYvbRN+/e72Ds= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:X-Google-DKIM-Signature:MIME-Version:Received:Received:In-Reply-To:References:Date:Message-ID:Subject:From:To:Content-Type:X-Gm-Message-State:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=KncOIfBEPrJYM+pbjUtgjb3aKMnX9MmhjxrVffWyMMGtDfyaV/Fw9G6gtlsJvg FiTSUTw4bDNuCnYXEcsCacmOQaR+87vCYTV5I7IQ4bUmwEOYT69fUJ6669knTMQR TcR3T5IL/sAnLpANroZwhstljzbExEldr0t/FXoQ0JAoI=; Received: (qmail 17735 invoked by alias); 20 Dec 2012 01:22:30 -0000 Received: (qmail 17613 invoked by uid 22791); 20 Dec 2012 01:22:28 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, KHOP_RCVD_TRUST, KHOP_THREADED, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-ie0-f178.google.com (HELO mail-ie0-f178.google.com) (209.85.223.178) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 20 Dec 2012 01:22:23 +0000 Received: by mail-ie0-f178.google.com with SMTP id c12so3742999ieb.23 for ; Wed, 19 Dec 2012 17:22:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:x-gm-message-state; bh=zpXTvYROYVjCpQD96QdKO7SsLumdEET+s1FqwdmGAcU=; b=OZyoNC/NewnQbT1HqQM/ACtb2n+5PZJjh68qqmNPAGiJhSkuIslYcvRdl45iqynG50 JWu0nDNfCcf6xEG/lkok2e7wEvlo/kJ6bxr+HRH8eyb5KqI06g/cOox9/hwrrRQRDVOg 5VOuRyFOD6dkS8DVucXpKAobVlrdjKTbckZCYh6boDE4/4fFwoXdRORRJprHeQ6PV2oE DWAxGo48HjxLVtmLHFL66DT6iYm6hYGi5bpsMKdOJt6ONIF/QV+wNvbfAvEU8Ipy4NWo 3bBhdkjE59UNzw8Zsudp4WyGgn5V39oqBzagLDBrriCo6vrCVQIKRxW7GgcWM/HvakB6 MZCg== MIME-Version: 1.0 Received: by 10.50.33.212 with SMTP id t20mr4137381igi.108.1355966543135; Wed, 19 Dec 2012 17:22:23 -0800 (PST) Received: by 10.231.79.5 with HTTP; Wed, 19 Dec 2012 17:22:22 -0800 (PST) In-Reply-To: <089e013a2ef42aa48e04d13e51e6@google.com> References: <089e013a2ef42aa48e04d13e51e6@google.com> Date: Wed, 19 Dec 2012 17:22:22 -0800 Message-ID: Subject: Re: [google 4.7] fdo build for linux kernel (issue 6968046) From: Rong Xu To: xur@google.com, davidxl@google.com, gcc-patches@gcc.gnu.org, reply@codereview-hr.appspotmail.com X-Gm-Message-State: ALoCoQkx0aHyk3w1+GPy2DFeDhHsiK7h/+VKW6Kx3XZc7Uh4tJ2KcDclbq5+2WKj8N0LXpldDmf1ZZbKpZj7sQL7zISQ3rtxAuyMSccWOhYgj9dIGTfk5KVahkbAvEqKuA39fXIsYJnPtpUZYl7eVbdDtnotjfYRvut4WQKbJz42RDPL4vAmoGjGTl4dhAiVAcn66aVl5e/W X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Wed, Dec 19, 2012 at 5:04 PM, wrote: > The change in gcov-io.h is from a different patch. sorry. here is the patch for gcov-io.h: GCOV_LINKAGE void gcov_sync (gcov_position_t /*base*/, > > David > > > https://codereview.appspot.com/6968046/diff/1/gcc/gcov-io.c > File gcc/gcov-io.c (right): > > https://codereview.appspot.com/6968046/diff/1/gcc/gcov-io.c#newcode688 > gcc/gcov-io.c:688: > Have you compared this with this impl: > > while (x) > { > c++; > x&=(x-1) > } > return c; > I did not try this pimplier version. I can do a test on the dump speed and report back. > https://codereview.appspot.com/6968046/ Index: gcov-io.h =================================================================== --- gcov-io.h (revision 194562) +++ gcov-io.h (working copy) @@ -781,8 +781,8 @@ unused) */ unsigned n_functions; /* number of functions */ - const struct gcov_fn_info *const *functions; /* pointer to pointers - to function information */ + const struct gcov_fn_info **functions; /* pointer to pointers + to function information */ }; /* Information about a single imported module. */ @@ -988,8 +988,7 @@ GCOV_LINKAGE void gcov_seek (gcov_position_t /*position*/) ATTRIBUTE_HIDDEN; GCOV_LINKAGE void gcov_truncate (void) ATTRIBUTE_HIDDEN; GCOV_LINKAGE gcov_unsigned_t gcov_string_length (const char *) ATTRIBUTE_HIDDEN; -GCOV_LINKAGE unsigned gcov_gcda_file_size (struct gcov_info *, - struct gcov_summary *); +GCOV_LINKAGE unsigned gcov_gcda_file_size (struct gcov_info *); #else /* Available outside libgcov */