Patchwork [Fortran] PR54818 - Fix ICE with TRANSFER to char

login
register
mail settings
Submitter Tobias Burnus
Date Dec. 19, 2012, 11:29 p.m.
Message ID <50D24DEB.9090802@net-b.de>
Download mbox | patch
Permalink /patch/207550/
State New
Headers show

Comments

Tobias Burnus - Dec. 19, 2012, 11:29 p.m.
TRANSFER(..., "string") created on x86-64 an integer(8) string length; 
that lead to a tree-checking ICE but also might pass the wrong type in 
'call sub(transfer(233," ")'.

Build and regtested on x86-64-gnu-linux.
OK for the trunk?

Tobias
Paul Richard Thomas - Dec. 19, 2012, 11:59 p.m.
Dear Tobias,

OK for trunk, apart from:
s/the string length if of type gfc_charlen_type_node/the string length
is of type gfc_charlen_type_node/

Thanks for the patch

Paul

On 20 December 2012 00:29, Tobias Burnus <burnus@net-b.de> wrote:
> TRANSFER(..., "string") created on x86-64 an integer(8) string length; that
> lead to a tree-checking ICE but also might pass the wrong type in 'call
> sub(transfer(233," ")'.
>
> Build and regtested on x86-64-gnu-linux.
> OK for the trunk?
>
> Tobias

Patch

2012-12-20  Tobias Burnus  <burnus@net-b.de>

	PR fortran/54818
	* trans-intrinsic.c (gfc_conv_intrinsic_transfer): Ensure that
	the string length if of type gfc_charlen_type_node.

2012-12-20  Tobias Burnus  <burnus@net-b.de>

	PR fortran/54818
	* gfortran.dg/transfer_intrinsic_4.f: New.

diff --git a/gcc/fortran/trans-intrinsic.c b/gcc/fortran/trans-intrinsic.c
index 4f74c3f..b1e6a2e 100644
--- a/gcc/fortran/trans-intrinsic.c
+++ b/gcc/fortran/trans-intrinsic.c
@@ -5662,7 +5662,7 @@  scalar_transfer:
       gfc_add_expr_to_block (&se->pre, tmp);
 
       se->expr = tmpdecl;
-      se->string_length = dest_word_len;
+      se->string_length = fold_convert (gfc_charlen_type_node, dest_word_len);
     }
   else
     {
diff --git a/gcc/testsuite/gfortran.dg/transfer_intrinsic_4.f b/gcc/testsuite/gfortran.dg/transfer_intrinsic_4.f
new file mode 100644
index 0000000..4173afd
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/transfer_intrinsic_4.f
@@ -0,0 +1,27 @@ 
+! { dg-do compile }
+!
+! PR fortran/54818
+!
+! Contributed by  Scott Pakin
+!
+      subroutine broken ( name1, name2, bmix )
+
+      implicit none
+
+      integer, parameter :: i_knd  = kind( 1 )
+      integer, parameter :: r_knd  = selected_real_kind( 13 )
+
+      character(len=8) :: dum
+      character(len=8) :: blk
+      real(r_knd), dimension(*) :: bmix, name1, name2
+      integer(i_knd) :: j, idx1, n, i
+      integer(i_knd), external :: nafix
+
+      write (*, 99002) name1(j),
+     &     ( adjustl(
+     &     transfer(name2(nafix(bmix(idx1+i),1)),dum)//blk
+     &     //blk), bmix(idx1+i+1), i = 1, n, 2 )
+
+99002 format (' *', 10x, a8, 8x, 3(a24,1pe12.5,',',6x))
+
+      end subroutine broken