From patchwork Wed Dec 19 22:08:15 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 207529 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id 223952C009A for ; Thu, 20 Dec 2012 09:08:31 +1100 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1TlRoK-0007nC-TU; Wed, 19 Dec 2012 22:08:20 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1TlRoJ-0007ms-DJ for kernel-team@lists.ubuntu.com; Wed, 19 Dec 2012 22:08:19 +0000 Received: from cpc3-craw6-2-0-cust180.croy.cable.virginmedia.com ([77.100.248.181] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1TlRoJ-0004AV-B0 for kernel-team@lists.ubuntu.com; Wed, 19 Dec 2012 22:08:19 +0000 From: Colin King To: kernel-team@lists.ubuntu.com Subject: [PATCH][Oneiric][SRU] UBUNTU: SAUCE: samsung-laptop: disable in UEFI mode Date: Wed, 19 Dec 2012 22:08:15 +0000 Message-Id: <1355954898-15402-2-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.8.0 In-Reply-To: <1355954898-15402-1-git-send-email-colin.king@canonical.com> References: <1355954898-15402-1-git-send-email-colin.king@canonical.com> X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.13 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: kernel-team-bounces@lists.ubuntu.com Errors-To: kernel-team-bounces@lists.ubuntu.com From: Colin Ian King BugLink: https://launchpad.net/bugs/1040557 Disable this driver if we've booted in UEFI mode as some Samsungs seem to get bricked and are rendered unbootable when this driver tries to poke around the BIOS controls when in UEFI. Signed-off-by: Colin Ian King --- drivers/platform/x86/samsung-laptop.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c index 7c42a4c..00ffed9 100644 --- a/drivers/platform/x86/samsung-laptop.c +++ b/drivers/platform/x86/samsung-laptop.c @@ -21,6 +21,7 @@ #include #include #include +#include /* * This driver is needed because a number of Samsung laptops do not hook @@ -793,6 +794,9 @@ static int __init samsung_init(void) int loca; int retval; + if (efi_enabled) + return -ENODEV; + mutex_init(&sabi_mutex); if (!force && !dmi_check_system(samsung_dmi_table))