From patchwork Wed Dec 19 15:34:32 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesper Nilsson X-Patchwork-Id: 207404 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-fa0-f60.google.com (mail-fa0-f60.google.com [209.85.161.60]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 7880E2C0093 for ; Thu, 20 Dec 2012 02:34:39 +1100 (EST) Received: by mail-fa0-f60.google.com with SMTP id m1sf677436fam.25 for ; Wed, 19 Dec 2012 07:34:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf :x-virus-scanned:date:from:to:cc:subject:message-id:references :mime-version:in-reply-to:user-agent:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type:content-disposition; bh=/qU9A4bWHPgqTlFB5d6uInYxPbpx2+kpdK0Dgm2NA34=; b=LInasgnlfASWTrmzWAUPgPPrg/WciKw+oTZgl+C9HHjXRaXTPL8P/v0eMAm/VSaH9i YdurnhO1Y1V/2PPkCkpXX8lDRJyj3gxyCDUSJV5KX10YoIWky6nzlx77aMZ0t4xyosKn I9Vea4f19LTRkCrkKJCePnv3Eoc/47XPGN1r9nMaw9S3xU+nHOAPTehoZoTubKYHeddx CfIMdGZEz4OsxiDPrM9tayNLrdeBMT4XCG8/eKcX7BPfHUjTMn1ubEGGlgZfKxBHFNh1 HHtd7407fccjGFps+F2EK+g7pNKbnAR6N11XlJHo+QP0Jzj0xNXGqEq/K2PP8SAYf8m0 Aa0A== X-Received: by 10.180.94.1 with SMTP id cy1mr1224477wib.5.1355931275934; Wed, 19 Dec 2012 07:34:35 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.180.82.100 with SMTP id h4ls798322wiy.33.gmail; Wed, 19 Dec 2012 07:34:35 -0800 (PST) X-Received: by 10.204.146.25 with SMTP id f25mr341963bkv.1.1355931275341; Wed, 19 Dec 2012 07:34:35 -0800 (PST) X-Received: by 10.204.146.25 with SMTP id f25mr341962bkv.1.1355931275325; Wed, 19 Dec 2012 07:34:35 -0800 (PST) Received: from anubis.se.axis.com (anubis.se.axis.com. [195.60.68.12]) by gmr-mx.google.com with ESMTP id j28si403085bkv.0.2012.12.19.07.34.35; Wed, 19 Dec 2012 07:34:35 -0800 (PST) Received-SPF: pass (google.com: domain of jesper.nilsson@axis.com designates 195.60.68.12 as permitted sender) client-ip=195.60.68.12; Received: from localhost (localhost [127.0.0.1]) by anubis.se.axis.com (Postfix) with ESMTP id 9BC8019E5B; Wed, 19 Dec 2012 16:34:34 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at anubis.se.axis.com Received: from anubis.se.axis.com ([127.0.0.1]) by localhost (anubis.se.axis.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Goog0Sqd5las; Wed, 19 Dec 2012 16:34:33 +0100 (CET) Received: from thoth.se.axis.com (thoth.se.axis.com [10.0.2.173]) by anubis.se.axis.com (Postfix) with ESMTP id 3513B19E53; Wed, 19 Dec 2012 16:34:32 +0100 (CET) Received: from lnxjespern2.se.axis.com (lnxjespern2.se.axis.com [10.88.4.6]) by thoth.se.axis.com (Postfix) with ESMTP id 32AE9341E7; Wed, 19 Dec 2012 16:34:32 +0100 (CET) Received: by lnxjespern2.se.axis.com (Postfix, from userid 363) id 2FBFAC069; Wed, 19 Dec 2012 16:34:32 +0100 (CET) Date: Wed, 19 Dec 2012 16:34:32 +0100 From: Jesper Nilsson To: Thierry Reding Cc: Andrew Morton , Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: [rtc-linux] [PATCH v2] rtc-pcf8523: Add low battery voltage support Message-ID: <20121219153432.GC14217@axis.com> References: <20121219140456.GA14217@axis.com> <20121219144225.GB7837@avionic-0098.adnet.avionic-design.de> <20121219151054.GB14217@axis.com> <20121219151937.GA21212@avionic-0098.adnet.avionic-design.de> MIME-Version: 1.0 In-Reply-To: <20121219151937.GA21212@avionic-0098.adnet.avionic-design.de> User-Agent: Mutt/1.5.20 (2009-06-14) X-Original-Sender: jesper.nilsson@axis.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jesper.nilsson@axis.com designates 195.60.68.12 as permitted sender) smtp.mail=jesper.nilsson@axis.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-Disposition: inline This patch implements reading of the battery voltage low signal for rtc-pcf8523. The bit is read-only and cannot be cleared by software, so no clear-function is implemented. Signed-off-by: Jesper Nilsson Reviewed-by: Thierry Reding --- /^JN - Jesper Nilsson diff --git a/drivers/rtc/rtc-pcf8523.c b/drivers/rtc/rtc-pcf8523.c index be05a64..62905fb 100644 --- a/drivers/rtc/rtc-pcf8523.c +++ b/drivers/rtc/rtc-pcf8523.c @@ -23,6 +23,7 @@ #define REG_CONTROL3_PM_VDD (1 << 6) /* switch-over disabled */ #define REG_CONTROL3_PM_DSM (1 << 5) /* direct switching mode */ #define REG_CONTROL3_PM_MASK 0xe0 +#define REG_CONTROL3_BLF (1 << 2) /* battery low bit, read-only */ #define REG_SECONDS 0x03 #define REG_SECONDS_OS (1 << 7) @@ -250,9 +252,36 @@ static int pcf8523_rtc_set_time(struct device *dev, struct rtc_time *tm) return pcf8523_start_rtc(client); } +static int +pcf8523_rtc_ioctl(struct device *dev, unsigned int cmd, unsigned long arg) +{ + struct i2c_client *client = to_i2c_client(dev); + u8 value; + int err; + int ret = 0; + + switch (cmd) { + case RTC_VL_READ: + err = pcf8523_read(client, REG_CONTROL3, &value); + if (err < 0) + return err; + + if (value & REG_CONTROL3_BLF) + ret = 1; + + if (copy_to_user((void __user *)arg, &ret, sizeof(int))) + return -EFAULT; + + return 0; + default: + return -ENOIOCTLCMD; + } +} + static const struct rtc_class_ops pcf8523_rtc_ops = { .read_time = pcf8523_rtc_read_time, .set_time = pcf8523_rtc_set_time, + .ioctl = pcf8523_rtc_ioctl, }; static int pcf8523_probe(struct i2c_client *client,