Patchwork [1/1] busybox-configure: Add mkfs.vfat option to busybox

login
register
mail settings
Submitter christian.braunersorensen@prevas.dk
Date Dec. 19, 2012, 9:25 a.m.
Message ID <9735cc2ede786bb79af275e5de77ba9d98a39cc9.1355909039.git.christian.braunersorensen@prevas.dk>
Download mbox | patch
Permalink /patch/207270/
State Accepted
Headers show

Comments

christian.braunersorensen@prevas.dk - Dec. 19, 2012, 9:25 a.m.
From: Christian Sørensen <christian.braunersorensen@prevas.dk>

---
 recipes/busybox/busybox-configure.inc | 3 +++
 1 file changed, 3 insertions(+)
Esben Haabendal - Dec. 21, 2012, 7:19 a.m.
<christian.braunersorensen@prevas.dk> writes:

> From: Christian Sørensen <christian.braunersorensen@prevas.dk>
>
> ---
>  recipes/busybox/busybox-configure.inc | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/recipes/busybox/busybox-configure.inc b/recipes/busybox/busybox-configure.inc
> index 037cd97..7fe7820 100644
> --- a/recipes/busybox/busybox-configure.inc
> +++ b/recipes/busybox/busybox-configure.inc
> @@ -619,6 +619,9 @@ BUSYBOX_SIMPLE_USE_FLAGS += "mount=1:util/"
>  # USE flag: enable feature_mount nfs
>  BUSYBOX_SIMPLE_USE_FLAGS += "feature_mount_nfs"
>  
> +# USE flag: enable mkfs vfat
> +BUSYBOX_SIMPLE_USE_FLAGS += "mkfs_vfat"
> +

Shouldn't we make that "mkfs_vfat:util/" as we do for other busybox
utility USE flags?

>  # USE flag: enable pivot root utility
>  BUSYBOX_SIMPLE_USE_FLAGS += "pivot_root:util/"

/Esben
Esben Haabendal - Dec. 21, 2012, 12:49 p.m.
Esben Haabendal <esben.haabendal@dev.prevas.dk> writes:

> <christian.braunersorensen@prevas.dk> writes:
>
>> From: Christian Sørensen <christian.braunersorensen@prevas.dk>
>>
>> ---
>>  recipes/busybox/busybox-configure.inc | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/recipes/busybox/busybox-configure.inc b/recipes/busybox/busybox-configure.inc
>> index 037cd97..7fe7820 100644
>> --- a/recipes/busybox/busybox-configure.inc
>> +++ b/recipes/busybox/busybox-configure.inc
>> @@ -619,6 +619,9 @@ BUSYBOX_SIMPLE_USE_FLAGS += "mount=1:util/"
>>  # USE flag: enable feature_mount nfs
>>  BUSYBOX_SIMPLE_USE_FLAGS += "feature_mount_nfs"
>>  
>> +# USE flag: enable mkfs vfat
>> +BUSYBOX_SIMPLE_USE_FLAGS += "mkfs_vfat"
>> +
>
> Shouldn't we make that "mkfs_vfat:util/" as we do for other busybox
> utility USE flags?
>
>>  # USE flag: enable pivot root utility
>>  BUSYBOX_SIMPLE_USE_FLAGS += "pivot_root:util/"

Merged to master with the above mentioned change.

/Esben

Patch

diff --git a/recipes/busybox/busybox-configure.inc b/recipes/busybox/busybox-configure.inc
index 037cd97..7fe7820 100644
--- a/recipes/busybox/busybox-configure.inc
+++ b/recipes/busybox/busybox-configure.inc
@@ -619,6 +619,9 @@  BUSYBOX_SIMPLE_USE_FLAGS += "mount=1:util/"
 # USE flag: enable feature_mount nfs
 BUSYBOX_SIMPLE_USE_FLAGS += "feature_mount_nfs"
 
+# USE flag: enable mkfs vfat
+BUSYBOX_SIMPLE_USE_FLAGS += "mkfs_vfat"
+
 # USE flag: enable pivot root utility
 BUSYBOX_SIMPLE_USE_FLAGS += "pivot_root:util/"