From patchwork Tue Dec 18 16:51:16 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 207170 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 25BB92C008E for ; Wed, 19 Dec 2012 05:12:49 +1100 (EST) Received: from localhost ([::1]:60721 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tl0Om-00035e-7k for incoming@patchwork.ozlabs.org; Tue, 18 Dec 2012 11:52:08 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48816) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tl0OQ-0002TN-Bn for qemu-devel@nongnu.org; Tue, 18 Dec 2012 11:51:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tl0OK-0005Sb-BM for qemu-devel@nongnu.org; Tue, 18 Dec 2012 11:51:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48832) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tl0OK-0005SS-3T for qemu-devel@nongnu.org; Tue, 18 Dec 2012 11:51:40 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBIGpdkd006000 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 18 Dec 2012 11:51:39 -0500 Received: from localhost (ovpn-112-27.ams2.redhat.com [10.36.112.27]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qBIGpc7X032260; Tue, 18 Dec 2012 11:51:38 -0500 From: Stefan Hajnoczi To: Date: Tue, 18 Dec 2012 17:51:16 +0100 Message-Id: <1355849477-1226-10-git-send-email-stefanha@redhat.com> In-Reply-To: <1355849477-1226-1-git-send-email-stefanha@redhat.com> References: <1355849477-1226-1-git-send-email-stefanha@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Anthony Liguori Subject: [Qemu-devel] [PATCH 09/10] vmmouse_reset(): remove minimal code duplication X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Laszlo Ersek Commit 069ab0eb added a vmmouse_disable() call to vmmouse_reset(). vmmouse_disable() resets the status already. Signed-off-by: Laszlo Ersek Signed-off-by: Stefan Hajnoczi --- hw/vmmouse.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/vmmouse.c b/hw/vmmouse.c index 6338efa..578122c 100644 --- a/hw/vmmouse.c +++ b/hw/vmmouse.c @@ -252,7 +252,6 @@ static void vmmouse_reset(DeviceState *d) { VMMouseState *s = container_of(d, VMMouseState, dev.qdev); - s->status = 0xffff; s->queue_size = VMMOUSE_QUEUE_SIZE; vmmouse_disable(s);