Patchwork [AARCH64] Fix warning in aarch64.md

login
register
mail settings
Submitter James Greenhalgh
Date Dec. 18, 2012, 2:07 p.m.
Message ID <1355839635-13552-1-git-send-email-james.greenhalgh@arm.com>
Download mbox | patch
Permalink /patch/207127/
State New
Headers show

Comments

James Greenhalgh - Dec. 18, 2012, 2:07 p.m.
Hi,

This obvious patch fixes the following warnings I see when building for
AArch64.

gcc/config/aarch64/aarch64.md:840: warning: source missing a mode?
gcc/config/aarch64/aarch64.md:840: warning: source missing a mode?

I've tested on aarch64-none-elf with no regressions and the patch
clears the warnings.

Is this OK to commit?

Thanks,
James Greenhalgh

---
gcc/
2012-12-18  James Greenhalgh  <james.greenhalgh@arm.com>

	* config/aarch64/aarch64.md (insv_imm<mode>): Add modes
	for source operands.
Richard Earnshaw - Dec. 18, 2012, 4:36 p.m.
On 18/12/12 14:07, James Greenhalgh wrote:
>
> Hi,
>
> This obvious patch fixes the following warnings I see when building for
> AArch64.
>
> gcc/config/aarch64/aarch64.md:840: warning: source missing a mode?
> gcc/config/aarch64/aarch64.md:840: warning: source missing a mode?
>
> I've tested on aarch64-none-elf with no regressions and the patch
> clears the warnings.
>
> Is this OK to commit?
>

OK.

R.

Patch

diff --git a/gcc/config/aarch64/aarch64.md b/gcc/config/aarch64/aarch64.md
index b59d53d..28f32da 100644
--- a/gcc/config/aarch64/aarch64.md
+++ b/gcc/config/aarch64/aarch64.md
@@ -840,8 +840,8 @@ 
 (define_insn "insv_imm<mode>"
   [(set (zero_extract:GPI (match_operand:GPI 0 "register_operand" "+r")
 			  (const_int 16)
-			  (match_operand 1 "const_int_operand" "n"))
-	(match_operand 2 "const_int_operand" "n"))]
+			  (match_operand:GPI 1 "const_int_operand" "n"))
+	(match_operand:GPI 2 "const_int_operand" "n"))]
   "INTVAL (operands[1]) < GET_MODE_BITSIZE (<MODE>mode)
    && INTVAL (operands[1]) % 16 == 0
    && INTVAL (operands[2]) <= 0xffff"