Patchwork sg3-utils new package.

login
register
mail settings
Submitter Marek Belisko
Date Dec. 17, 2012, 8:35 p.m.
Message ID <1355776546-25189-1-git-send-email-marek.belisko@open-nandra.com>
Download mbox | patch
Permalink /patch/206997/
State Superseded
Headers show

Comments

Marek Belisko - Dec. 17, 2012, 8:35 p.m.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
---
 package/Config.in              |    1 +
 package/sg3_utils/Config.in    |    7 +++++++
 package/sg3_utils/sg3_utils.mk |   10 ++++++++++
 3 files changed, 18 insertions(+)
 create mode 100644 package/sg3_utils/Config.in
 create mode 100644 package/sg3_utils/sg3_utils.mk
Arnout Vandecappelle - Dec. 17, 2012, 11:10 p.m.
On 17/12/12 21:35, Marek Belisko wrote:
> Signed-off-by: Marek Belisko<marek.belisko@open-nandra.com>
[snip]
> diff --git a/package/sg3_utils/Config.in b/package/sg3_utils/Config.in
> new file mode 100644
> index 0000000..1d2ab2a
> --- /dev/null
> +++ b/package/sg3_utils/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_SG3_UTILS
> +	bool "sg3_utils"

  depends on BR2_LARGEFILE
  depends on BR2_TOOLCHAIN_HAS_THREADS
  (actually only sgp_dd needs threads so that could be patched out in the 
Makefile).

  Not sure about IPv6.


  Otherwise, looks good.

  Regards,
  Arnout
Thomas Petazzoni - Dec. 18, 2012, 8:48 a.m.
Dear Marek Belisko,

On Mon, 17 Dec 2012 21:35:46 +0100, Marek Belisko wrote:

> +SG3_UTILS_INSTALL_STAGING = YES

Hum, why is this needed? Does sg3_utils installs some libraries or
headers that are useful for other packages?

Thanks,

Thomas
Belisko Marek - Dec. 18, 2012, 8:52 a.m.
Hi Thomas,

On Tue, Dec 18, 2012 at 9:48 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Marek Belisko,
>
> On Mon, 17 Dec 2012 21:35:46 +0100, Marek Belisko wrote:
>
>> +SG3_UTILS_INSTALL_STAGING = YES
>
> Hum, why is this needed? Does sg3_utils installs some libraries or
> headers that are useful for other packages?
I'm working on adding udisks to buildroot and udisks have dependency on
sg3-utils library so this is the reason why installing to staging.
I've read somewhere on ML you was working also on udisks package.
Was it successful?
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com

Cheers,

mbe
Thomas Petazzoni - Dec. 18, 2012, 9:03 a.m.
Dear Belisko Marek,

On Tue, 18 Dec 2012 09:52:41 +0100, Belisko Marek wrote:

> > Hum, why is this needed? Does sg3_utils installs some libraries or
> > headers that are useful for other packages?
> I'm working on adding udisks to buildroot and udisks have dependency on
> sg3-utils library so this is the reason why installing to staging.

Ok. A comment just before the _INSTALL_STAGING line would be useful,
then, because for a "utils" package, we don't necessarily expect to
have a library in it.

> I've read somewhere on ML you was working also on udisks package.
> Was it successful?

It was a looong time ago. I think I managed to get udisks to build, but
I hadn't had the time to do some real testing with it: I was first
doing some testing of polkit, which is a dependency of udisks.

I've put online the 3 patches I had done at that time (note that they
are old: they still use the old AUTOTARGETS macro name), see:
http://free-electrons.com/~thomas/pub/udisks-buildroot/

Best regards,

Thomas
Belisko Marek - Dec. 19, 2012, 10:11 p.m.
Hi Thomas,

On Tue, Dec 18, 2012 at 10:03 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Belisko Marek,
>
> On Tue, 18 Dec 2012 09:52:41 +0100, Belisko Marek wrote:
>
>> > Hum, why is this needed? Does sg3_utils installs some libraries or
>> > headers that are useful for other packages?
>> I'm working on adding udisks to buildroot and udisks have dependency on
>> sg3-utils library so this is the reason why installing to staging.
>
> Ok. A comment just before the _INSTALL_STAGING line would be useful,
> then, because for a "utils" package, we don't necessarily expect to
> have a library in it.
>
>> I've read somewhere on ML you was working also on udisks package.
>> Was it successful?
>
> It was a looong time ago. I think I managed to get udisks to build, but
> I hadn't had the time to do some real testing with it: I was first
> doing some testing of polkit, which is a dependency of udisks.
>
> I've put online the 3 patches I had done at that time (note that they
> are old: they still use the old AUTOTARGETS macro name), see:
> http://free-electrons.com/~thomas/pub/udisks-buildroot/
Thanks for patches. I made small update and I can compile polkit without
problems but I have still problems with udisks.

Basically udisks have only autogen.sh script and I was trying to use:
UDISKS_AUTORECONF = YES macro.

With this change it fails during autoreconfiguring:

configure.ac:13: the top level
configure.ac:225: warning: AM_NLS is m4_require'd but not m4_defun'd
aclocal.m4:1204: IT_PROG_INTLTOOL is expanded from...
configure.ac:225: the top level
configure:14234: error: possibly undefined macro: AM_NLS
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.

Am I missing some dependency?

>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com

Thanks,

marek
Thomas Petazzoni - Dec. 19, 2012, 10:36 p.m.
Dear Belisko Marek,

On Wed, 19 Dec 2012 23:11:31 +0100, Belisko Marek wrote:

> configure.ac:13: the top level
> configure.ac:225: warning: AM_NLS is m4_require'd but not m4_defun'd
> aclocal.m4:1204: IT_PROG_INTLTOOL is expanded from...
> configure.ac:225: the top level
> configure:14234: error: possibly undefined macro: AM_NLS
>       If this token and others are legitimate, please use m4_pattern_allow.
>       See the Autoconf documentation.
> 
> Am I missing some dependency?

I guess this macro is installed by gettext, but not sure.

Thomas
Belisko Marek - Dec. 20, 2012, 10:58 a.m.
Hi Thomas,

On Wed, Dec 19, 2012 at 11:36 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Belisko Marek,
>
> On Wed, 19 Dec 2012 23:11:31 +0100, Belisko Marek wrote:
>
>> configure.ac:13: the top level
>> configure.ac:225: warning: AM_NLS is m4_require'd but not m4_defun'd
>> aclocal.m4:1204: IT_PROG_INTLTOOL is expanded from...
>> configure.ac:225: the top level
>> configure:14234: error: possibly undefined macro: AM_NLS
>>       If this token and others are legitimate, please use m4_pattern_allow.
>>       See the Autoconf documentation.
>>
>> Am I missing some dependency?
>
> I guess this macro is installed by gettext, but not sure.
Hmm it was my mistake somehow. I proceed forward but now have troubles
in configuration phase:
checking for LIBPARTED... yes
checking for DEVMAPPER... no
configure: error: Package requirements (devmapper >= 1.02) were not met:

I choose BR2_PACKAGE_LVM2 and aso add dependency to lvm2 but error still exists.
I was looking to stagin directory and libdevmapper is is /usr/lib. Not
sure why it pkg-config cannot
find. Ideas?
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com

Thanks in advance,

Marek

Patch

diff --git a/package/Config.in b/package/Config.in
index d6af55d..269b3ff 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -253,6 +253,7 @@  source "package/rng-tools/Config.in"
 source "package/sane-backends/Config.in"
 source "package/sdparm/Config.in"
 source "package/setserial/Config.in"
+source "package/sg3_utils/Config.in"
 source "package/smartmontools/Config.in"
 source "package/snowball-hdmiservice/Config.in"
 source "package/sredird/Config.in"
diff --git a/package/sg3_utils/Config.in b/package/sg3_utils/Config.in
new file mode 100644
index 0000000..1d2ab2a
--- /dev/null
+++ b/package/sg3_utils/Config.in
@@ -0,0 +1,7 @@ 
+config BR2_PACKAGE_SG3_UTILS
+	bool "sg3_utils"
+	help
+	  sg3_utils is a package of utilities that send SCSI commands to the
+	  given <scsi_device> via a SCSI pass through.
+
+	  http://sg.danny.cz/sg/
diff --git a/package/sg3_utils/sg3_utils.mk b/package/sg3_utils/sg3_utils.mk
new file mode 100644
index 0000000..2eba3d3
--- /dev/null
+++ b/package/sg3_utils/sg3_utils.mk
@@ -0,0 +1,10 @@ 
+#############################################################
+#
+# sg3_utils
+#
+#############################################################
+SG3_UTILS_VERSION = 1.34
+SG3_UTILS_SITE = http://sg.danny.cz/sg/p/
+SG3_UTILS_INSTALL_STAGING = YES
+
+$(eval $(autotools-package))