Patchwork libglib2: fix g_print()

login
register
mail settings
Submitter Benoît Thébaudeau
Date Dec. 17, 2012, 8:05 p.m.
Message ID <1355774740-28679-1-git-send-email-benoit.thebaudeau@advansee.com>
Download mbox | patch
Permalink /patch/206995/
State Accepted
Commit 9a7e06dc83b70eaed900ab5078206e1c7d0ce141
Headers show

Comments

Benoît Thébaudeau - Dec. 17, 2012, 8:05 p.m.
If GLib is cross-compiled, the default printf settings that it selects are wrong
for glibc. This leads to issues with the g_print() functions, e.g. "Aborted"
errors returned by gst-inspect.

This patch fixes this issue by setting printf configuration options compatible
with glibc. These options should also be compatible with uClibc.

This solution has been suggested for LTIB by Rogerio Nunes:
https://community.freescale.com/thread/302734

Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau@advansee.com>
---
 package/libglib2/libglib2.mk |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Arnout Vandecappelle - Dec. 18, 2012, 8:29 a.m.
On 17/12/12 21:05, Benoît Thébaudeau wrote:
> If GLib is cross-compiled, the default printf settings that it selects are wrong
> for glibc. This leads to issues with the g_print() functions, e.g. "Aborted"
> errors returned by gst-inspect.
>
> This patch fixes this issue by setting printf configuration options compatible
> with glibc. These options should also be compatible with uClibc.
>
> This solution has been suggested for LTIB by Rogerio Nunes:
> https://community.freescale.com/thread/302734
>
> Signed-off-by: Benoît Thébaudeau<benoit.thebaudeau@advansee.com>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
  (fixes our aborts when doing gst-inspect on an i.MX6 platform)

  Regards,
  Arnout
Peter Korsgaard - Dec. 18, 2012, 8:38 a.m.
>>>>> "Benoît" == Benoît Thébaudeau <benoit.thebaudeau@advansee.com> writes:

 Benoît> If GLib is cross-compiled, the default printf settings that it
 Benoît> selects are wrong for glibc. This leads to issues with the
 Benoît> g_print() functions, e.g. "Aborted" errors returned by
 Benoît> gst-inspect.

 Benoît> This patch fixes this issue by setting printf configuration
 Benoît> options compatible with glibc. These options should also be
 Benoît> compatible with uClibc.

 Benoît> This solution has been suggested for LTIB by Rogerio Nunes:
 Benoît> https://community.freescale.com/thread/302734

Committed, thanks.

Patch

diff --git a/package/libglib2/libglib2.mk b/package/libglib2/libglib2.mk
index 4427431..c3e510b 100644
--- a/package/libglib2/libglib2.mk
+++ b/package/libglib2/libglib2.mk
@@ -40,7 +40,8 @@  LIBGLIB2_CONF_ENV = \
 		ac_cv_func_working_mktime=yes jm_cv_func_working_re_compile_pattern=yes \
 		ac_use_included_regex=no gl_cv_c_restrict=no \
 		ac_cv_path_GLIB_GENMARSHAL=$(HOST_DIR)/usr/bin/glib-genmarshal ac_cv_prog_F77=no \
-		ac_cv_func_posix_getgrgid_r=no \
+		ac_cv_func_posix_getgrgid_r=no glib_cv_long_long_format=ll \
+		ac_cv_func_printf_unix98=yes ac_cv_func_vsnprintf_c99=yes \
 		gt_cv_c_wchar_t=$(if $(BR2_USE_WCHAR),yes,no)
 
 # old uClibc versions don't provide qsort_r