Patchwork block/raw-win32: Fix compiler warnings (wrong format specifiers)

login
register
mail settings
Submitter Stefan Weil
Date Dec. 17, 2012, 7:40 p.m.
Message ID <1355773201-11576-1-git-send-email-sw@weilnetz.de>
Download mbox | patch
Permalink /patch/206985/
State Accepted
Headers show

Comments

Stefan Weil - Dec. 17, 2012, 7:40 p.m.
Commit fbcad04d6bfdff937536eb23088a01a280a1a3af added fprintf statements
with wrong format specifiers.

GetLastError() returns a DWORD which is unsigned long, so %lu must be used.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---

Do we want those fprintf statements here at all?

- Stefan

 block/raw-win32.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Andreas Färber - Dec. 17, 2012, 7:44 p.m.
Am 17.12.2012 20:40, schrieb Stefan Weil:
> Commit fbcad04d6bfdff937536eb23088a01a280a1a3af added fprintf statements
> with wrong format specifiers.
> 
> GetLastError() returns a DWORD which is unsigned long, so %lu must be used.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> 
> Do we want those fprintf statements here at all?

I believe it was argued that otherwise you cannot distinguish where the
EIO came from.

Andreas

>  block/raw-win32.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/block/raw-win32.c b/block/raw-win32.c
> index ce207a3..a2e155e 100644
> --- a/block/raw-win32.c
> +++ b/block/raw-win32.c
> @@ -314,11 +314,11 @@ static int raw_truncate(BlockDriverState *bs, int64_t offset)
>       */
>      dwPtrLow = SetFilePointer(s->hfile, low, &high, FILE_BEGIN);
>      if (dwPtrLow == INVALID_SET_FILE_POINTER && GetLastError() != NO_ERROR) {
> -        fprintf(stderr, "SetFilePointer error: %d\n", GetLastError());
> +        fprintf(stderr, "SetFilePointer error: %lu\n", GetLastError());
>          return -EIO;
>      }
>      if (SetEndOfFile(s->hfile) == 0) {
> -        fprintf(stderr, "SetEndOfFile error: %d\n", GetLastError());
> +        fprintf(stderr, "SetEndOfFile error: %lu\n", GetLastError());
>          return -EIO;
>      }
>      return 0;
>
Fabien Chouteau - Dec. 18, 2012, 1:26 p.m.
On 12/17/2012 08:40 PM, Stefan Weil wrote:
> Commit fbcad04d6bfdff937536eb23088a01a280a1a3af added fprintf statements
> with wrong format specifiers.
> 
> GetLastError() returns a DWORD which is unsigned long, so %lu must be used.
> 

That's right, I didn't see that.

Thanks Stefan,
Stefan Hajnoczi - Dec. 18, 2012, 3:23 p.m.
On Mon, Dec 17, 2012 at 08:40:01PM +0100, Stefan Weil wrote:
> Commit fbcad04d6bfdff937536eb23088a01a280a1a3af added fprintf statements
> with wrong format specifiers.
> 
> GetLastError() returns a DWORD which is unsigned long, so %lu must be used.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> 
> Do we want those fprintf statements here at all?
> 
> - Stefan
> 
>  block/raw-win32.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks, applied to the block patches tree:
https://github.com/stefanha/qemu/commits/block

Stefan

Patch

diff --git a/block/raw-win32.c b/block/raw-win32.c
index ce207a3..a2e155e 100644
--- a/block/raw-win32.c
+++ b/block/raw-win32.c
@@ -314,11 +314,11 @@  static int raw_truncate(BlockDriverState *bs, int64_t offset)
      */
     dwPtrLow = SetFilePointer(s->hfile, low, &high, FILE_BEGIN);
     if (dwPtrLow == INVALID_SET_FILE_POINTER && GetLastError() != NO_ERROR) {
-        fprintf(stderr, "SetFilePointer error: %d\n", GetLastError());
+        fprintf(stderr, "SetFilePointer error: %lu\n", GetLastError());
         return -EIO;
     }
     if (SetEndOfFile(s->hfile) == 0) {
-        fprintf(stderr, "SetEndOfFile error: %d\n", GetLastError());
+        fprintf(stderr, "SetEndOfFile error: %lu\n", GetLastError());
         return -EIO;
     }
     return 0;