From patchwork Mon Dec 17 16:42:17 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jan-Benedict Glaw X-Patchwork-Id: 206917 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 64B672C0094 for ; Tue, 18 Dec 2012 03:43:38 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1356367419; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Date: From:To:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:User-Agent:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=K1wee5Qyvkme0p2aS0GKcMfiSyM=; b=vk/Eul+wia4/LtZ GYO+PVwoasig2rcG4cuz5QkrzYMzd4sLQOasJgZ6+1nfMTGm5yiJz/yz25BcT3T4 YxPrvQzFnAHfjDoRvruFQvDtBxkEfOCOv5/fZ0JEDavfQi3DEttmjESAArSpAFC8 ymEpfsykGsJlOs2YM7C9coEsDRB8= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Date:From:To:Subject:Message-ID:MIME-Version:Content-Type:Content-Disposition:X-gpg-fingerprint:X-gpg-key:X-Echelon-Enable:X-TKUeV:User-Agent:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=CAaZpothJOwtKMOz6HfmNTT+J/heCNI7FPn/5Vtp7DDmLyl+Huffed6JGjos+/ 40NxDrh/jP36Dr78pNFN0sZLWD+cjKgd5VqWdxLR0/eAv/gO9GS3pPKPa8olgkun 4x/7/0A0Q2csKfT2zUfbCHuNQAfz/4T3aAUpHMidXLBdM=; Received: (qmail 8712 invoked by alias); 17 Dec 2012 16:43:30 -0000 Received: (qmail 8631 invoked by uid 22791); 17 Dec 2012 16:43:28 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL, BAYES_00, BOTNET, KHOP_PGP_SIGNED, RDNS_NONE X-Spam-Check-By: sourceware.org Received: from Unknown (HELO lug-owl.de) (195.71.106.12) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 17 Dec 2012 16:42:24 +0000 Received: by lug-owl.de (Postfix, from userid 1001) id A33B4F00D1; Mon, 17 Dec 2012 17:42:17 +0100 (CET) Date: Mon, 17 Dec 2012 17:42:17 +0100 From: Jan-Benedict Glaw To: John David Anglin , GCC Patches Subject: [PATCH] Fix recent warning about pending_assemble_externals_processed Message-ID: <20121217164217.GF10671@lug-owl.de> MIME-Version: 1.0 Content-Disposition: inline X-gpg-fingerprint: 250D 3BCF 7127 0D8C A444 A961 1DBD 5E75 8399 E1BB X-gpg-key: wwwkeys.de.pgp.net X-Echelon-Enable: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll X-TKUeV: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hi! I'd like to apply the following patch to fix a warning: ../../../../gcc/gcc/varasm.c:2094:13: warning: ‘pending_assemble_externals_processed’ defined but not used [-Wunused-variable] (seen on microblaze-uclinux and pdp11-aout) introduced with a fix for PR middle-end/55709 and 52894: +2012-12-16 John David Anglin + + PR middle-end/55709 + Forward port from 4.7 branch: + 2012-04-10 John David Anglin + + PR middle-end/52894 + * varasm.c (process_pending_assemble_externals): Set + pending_assemble_externals_processed true. + (assemble_external): Call assemble_external_real if the pending + assemble externals have been processed. Okay to commit? 2012-12-17 Jan-Benedict Glaw * gcc/varasm.c (pending_assemble_externals_processed): Guard with ASM_OUTPUT_EXTERNAL. diff --git a/gcc/varasm.c b/gcc/varasm.c index daeb6e2..53ebfbf 100644 --- a/gcc/varasm.c +++ b/gcc/varasm.c @@ -2088,12 +2088,12 @@ contains_pointers_p (tree type) it all the way to final. See PR 17982 for further discussion. */ static GTY(()) tree pending_assemble_externals; +#ifdef ASM_OUTPUT_EXTERNAL /* Some targets delay some output to final using TARGET_ASM_FILE_END. As a result, assemble_external can be called after the list of externals is processed and the pointer set destroyed. */ static bool pending_assemble_externals_processed; -#ifdef ASM_OUTPUT_EXTERNAL /* Avoid O(external_decls**2) lookups in the pending_assemble_externals TREE_LIST in assemble_external. */ static struct pointer_set_t *pending_assemble_externals_set;