From patchwork Mon Dec 17 16:42:17 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Fix recent warning about pending_assemble_externals_processed From: Jan-Benedict Glaw X-Patchwork-Id: 206917 Message-Id: <20121217164217.GF10671@lug-owl.de> To: John David Anglin , GCC Patches Date: Mon, 17 Dec 2012 17:42:17 +0100 Hi! I'd like to apply the following patch to fix a warning: ../../../../gcc/gcc/varasm.c:2094:13: warning: ‘pending_assemble_externals_processed’ defined but not used [-Wunused-variable] (seen on microblaze-uclinux and pdp11-aout) introduced with a fix for PR middle-end/55709 and 52894: +2012-12-16 John David Anglin + + PR middle-end/55709 + Forward port from 4.7 branch: + 2012-04-10 John David Anglin + + PR middle-end/52894 + * varasm.c (process_pending_assemble_externals): Set + pending_assemble_externals_processed true. + (assemble_external): Call assemble_external_real if the pending + assemble externals have been processed. Okay to commit? 2012-12-17 Jan-Benedict Glaw * gcc/varasm.c (pending_assemble_externals_processed): Guard with ASM_OUTPUT_EXTERNAL. diff --git a/gcc/varasm.c b/gcc/varasm.c index daeb6e2..53ebfbf 100644 --- a/gcc/varasm.c +++ b/gcc/varasm.c @@ -2088,12 +2088,12 @@ contains_pointers_p (tree type) it all the way to final. See PR 17982 for further discussion. */ static GTY(()) tree pending_assemble_externals; +#ifdef ASM_OUTPUT_EXTERNAL /* Some targets delay some output to final using TARGET_ASM_FILE_END. As a result, assemble_external can be called after the list of externals is processed and the pointer set destroyed. */ static bool pending_assemble_externals_processed; -#ifdef ASM_OUTPUT_EXTERNAL /* Avoid O(external_decls**2) lookups in the pending_assemble_externals TREE_LIST in assemble_external. */ static struct pointer_set_t *pending_assemble_externals_set;