Patchwork data: klog.json: Add more specfic parse/execution failure checks on timeouts

login
register
mail settings
Submitter Colin King
Date Dec. 17, 2012, 11:46 a.m.
Message ID <1355744769-629-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/206840/
State Accepted
Headers show

Comments

Colin King - Dec. 17, 2012, 11:46 a.m.
From: Colin Ian King <colin.king@canonical.com>

Some ACPI parse/execution failure error messages from the kernel are caused
by device timeouts, so handle the specific EC timeout error and also the more
generic device timeout errors.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)
Keng-Yu Lin - Dec. 18, 2012, 10:04 a.m.
On Mon, Dec 17, 2012 at 7:46 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Some ACPI parse/execution failure error messages from the kernel are caused
> by device timeouts, so handle the specific EC timeout error and also the more
> generic device timeout errors.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/data/klog.json b/data/klog.json
> index adb0014..00c44e7 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -2723,11 +2723,27 @@
>     "label": "KlogAcpiMethodNoReturnValue"
>    },
>    {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI_PARSE_EXEC_FAIL",
> +   "pattern": "Method parse/execution failed.*EC.*AE_TIME",
> +   "advice": "The ACPI driver encounted an error executing some ACPI AML code which originated from the Embedded Controller (EC) timing out while waiting for a transaction to complete. This could indicate that either EC interrupts are being disabled or that the EC has temporarily gone offline or locked up, so this could be a kernel error or more probably a bug in the EC firmware.  See the kernel driver drivers/acpi/ec.c.  One can increase EC timeouts using the kernel parameter ec_delay to specify the timeout in milliseconds, the default is 500.",
> +   "label": "KlogAcpiEcTimeout"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI_PARSE_EXEC_FAIL",
> +   "pattern": "Method parse/execution failed.*AE_TIME",
> +   "advice": "The ACPI driver encounted an error executing some ACPI AML code which originated from a device timing out.",
> +   "label": "KlogAcpiTimeout"
> +  },
> +  {
>     "compare_mode": "string",
>     "log_level": "LOG_LEVEL_HIGH",
>     "tag": "FWTS_TAG_ACPI_PARSE_EXEC_FAIL",
>     "pattern": "Method parse/execution failed",
> -   "advice": "The ACPI driver encounter a parse or execution error on some ACPI AML code. This is unexepcted and normally indicates that there is a bug in the compiled AML code.  It could be a programming fault or an AML compiler issue.  See acpi_ps_parse_aml().",
> +   "advice": "The ACPI driver encounted a parse or execution error on some ACPI AML code. This is unexepcted and normally indicates that there is a bug in the compiled AML code.  It could be a programming fault or an AML compiler issue.  See acpi_ps_parse_aml().",
>     "label": "KlogAcpiParseExecAmlFailed"
>    },
>    {
> --
> 1.8.0
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
> --
> fwts-devel mailing list
> fwts-devel@lists.ubuntu.com
> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel
Alex Hung - Dec. 21, 2012, 2:18 a.m.
On 12/17/2012 07:46 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Some ACPI parse/execution failure error messages from the kernel are caused
> by device timeouts, so handle the specific EC timeout error and also the more
> generic device timeout errors.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json | 18 +++++++++++++++++-
>   1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/data/klog.json b/data/klog.json
> index adb0014..00c44e7 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -2723,11 +2723,27 @@
>      "label": "KlogAcpiMethodNoReturnValue"
>     },
>     {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI_PARSE_EXEC_FAIL",
> +   "pattern": "Method parse/execution failed.*EC.*AE_TIME",
> +   "advice": "The ACPI driver encounted an error executing some ACPI AML code which originated from the Embedded Controller (EC) timing out while waiting for a transaction to complete. This could indicate that either EC interrupts are being disabled or that the EC has temporarily gone offline or locked up, so this could be a kernel error or more probably a bug in the EC firmware.  See the kernel driver drivers/acpi/ec.c.  One can increase EC timeouts using the kernel parameter ec_delay to specify the timeout in milliseconds, the default is 500.",
> +   "label": "KlogAcpiEcTimeout"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "tag": "FWTS_TAG_ACPI_PARSE_EXEC_FAIL",
> +   "pattern": "Method parse/execution failed.*AE_TIME",
> +   "advice": "The ACPI driver encounted an error executing some ACPI AML code which originated from a device timing out.",
> +   "label": "KlogAcpiTimeout"
> +  },
> +  {
>      "compare_mode": "string",
>      "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_TAG_ACPI_PARSE_EXEC_FAIL",
>      "pattern": "Method parse/execution failed",
> -   "advice": "The ACPI driver encounter a parse or execution error on some ACPI AML code. This is unexepcted and normally indicates that there is a bug in the compiled AML code.  It could be a programming fault or an AML compiler issue.  See acpi_ps_parse_aml().",
> +   "advice": "The ACPI driver encounted a parse or execution error on some ACPI AML code. This is unexepcted and normally indicates that there is a bug in the compiled AML code.  It could be a programming fault or an AML compiler issue.  See acpi_ps_parse_aml().",
>      "label": "KlogAcpiParseExecAmlFailed"
>     },
>     {
>
Acked-by: Alex Hung <alex.hung@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index adb0014..00c44e7 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -2723,11 +2723,27 @@ 
    "label": "KlogAcpiMethodNoReturnValue"
   },
   {
+   "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_ACPI_PARSE_EXEC_FAIL",
+   "pattern": "Method parse/execution failed.*EC.*AE_TIME",
+   "advice": "The ACPI driver encounted an error executing some ACPI AML code which originated from the Embedded Controller (EC) timing out while waiting for a transaction to complete. This could indicate that either EC interrupts are being disabled or that the EC has temporarily gone offline or locked up, so this could be a kernel error or more probably a bug in the EC firmware.  See the kernel driver drivers/acpi/ec.c.  One can increase EC timeouts using the kernel parameter ec_delay to specify the timeout in milliseconds, the default is 500.",
+   "label": "KlogAcpiEcTimeout"
+  },
+  {
+   "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_HIGH",
+   "tag": "FWTS_TAG_ACPI_PARSE_EXEC_FAIL",
+   "pattern": "Method parse/execution failed.*AE_TIME",
+   "advice": "The ACPI driver encounted an error executing some ACPI AML code which originated from a device timing out.",
+   "label": "KlogAcpiTimeout"
+  },
+  {
    "compare_mode": "string",
    "log_level": "LOG_LEVEL_HIGH",
    "tag": "FWTS_TAG_ACPI_PARSE_EXEC_FAIL",
    "pattern": "Method parse/execution failed",
-   "advice": "The ACPI driver encounter a parse or execution error on some ACPI AML code. This is unexepcted and normally indicates that there is a bug in the compiled AML code.  It could be a programming fault or an AML compiler issue.  See acpi_ps_parse_aml().",
+   "advice": "The ACPI driver encounted a parse or execution error on some ACPI AML code. This is unexepcted and normally indicates that there is a bug in the compiled AML code.  It could be a programming fault or an AML compiler issue.  See acpi_ps_parse_aml().",
    "label": "KlogAcpiParseExecAmlFailed"
   },
   {