Patchwork data: klog: Remove a duplicate timer BIOS bug check

login
register
mail settings
Submitter Colin King
Date Dec. 17, 2012, 11:18 a.m.
Message ID <1355743128-32487-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/206836/
State Accepted
Headers show

Comments

Colin King - Dec. 17, 2012, 11:18 a.m.
From: Colin Ian King <colin.king@canonical.com>

Remove a newer duplicate timer BIOS bug check, the older version
(much later in the database) has better advice and catches the
same bug.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json | 8 --------
 1 file changed, 8 deletions(-)
Keng-Yu Lin - Dec. 18, 2012, 3:47 a.m.
On Mon, Dec 17, 2012 at 7:18 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Remove a newer duplicate timer BIOS bug check, the older version
> (much later in the database) has better advice and catches the
> same bug.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json | 8 --------
>  1 file changed, 8 deletions(-)
>
> diff --git a/data/klog.json b/data/klog.json
> index a6a7382..adb0014 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -146,14 +146,6 @@
>     "label": "KlogAcpiMcfgNotin32BitMemorySpace"
>    },
>    {
> -   "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_HIGH",
> -   "tag": "FWTS_TAG_BIOS",
> -   "pattern": "MP-BIOS bug.*8254 timer not connected to IO-APIC",
> -   "advice": "The 8254 timer is not connected to an IO-APIC, this is invariably due to a misconfiguration in the BIOS.",
> -   "label": "KlogIoApic8254TimerNotConnected"
> -  },
> -  {
>     "compare_mode": "string",
>     "log_level": "LOG_LEVEL_HIGH",
>     "tag": "FWTS_TAG_ACPI",
> --
> 1.8.0
>
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Alex Hung - Dec. 20, 2012, 9:47 a.m.
On 12/17/2012 07:18 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Remove a newer duplicate timer BIOS bug check, the older version
> (much later in the database) has better advice and catches the
> same bug.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json | 8 --------
>   1 file changed, 8 deletions(-)
>
> diff --git a/data/klog.json b/data/klog.json
> index a6a7382..adb0014 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -146,14 +146,6 @@
>      "label": "KlogAcpiMcfgNotin32BitMemorySpace"
>     },
>     {
> -   "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_HIGH",
> -   "tag": "FWTS_TAG_BIOS",
> -   "pattern": "MP-BIOS bug.*8254 timer not connected to IO-APIC",
> -   "advice": "The 8254 timer is not connected to an IO-APIC, this is invariably due to a misconfiguration in the BIOS.",
> -   "label": "KlogIoApic8254TimerNotConnected"
> -  },
> -  {
>      "compare_mode": "string",
>      "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_TAG_ACPI",
>
Acked-by: Alex Hung <alex.hung@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index a6a7382..adb0014 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -146,14 +146,6 @@ 
    "label": "KlogAcpiMcfgNotin32BitMemorySpace"
   },
   {
-   "compare_mode": "regex",
-   "log_level": "LOG_LEVEL_HIGH",
-   "tag": "FWTS_TAG_BIOS",
-   "pattern": "MP-BIOS bug.*8254 timer not connected to IO-APIC",
-   "advice": "The 8254 timer is not connected to an IO-APIC, this is invariably due to a misconfiguration in the BIOS.",
-   "label": "KlogIoApic8254TimerNotConnected"
-  },
-  {
    "compare_mode": "string",
    "log_level": "LOG_LEVEL_HIGH",
    "tag": "FWTS_TAG_ACPI",