Patchwork jpeg: fix make source

login
register
mail settings
Submitter Arnout Vandecappelle
Date Dec. 17, 2012, 11:18 a.m.
Message ID <1355743111-18183-1-git-send-email-arnout@mind.be>
Download mbox | patch
Permalink /patch/206835/
State Accepted
Commit 7cba1dead6ce53ccd8ea1c634fc9589f1b2e956e
Headers show

Comments

Arnout Vandecappelle - Dec. 17, 2012, 11:18 a.m.
'make source' fails because the host-jpeg-source target doesn't exist
anymore. Fix this by adding this target explicitly.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
Note that this is only necessary because of the rather twisted way that
the top-level target and dependency lists are generated. Now that all
packages have been converted to gentargets it would probably be possible
to create all necessary dependencies in the package-generic macro, which
would remove the need for this patch.

 package/jpeg/jpeg.mk |    1 +
 1 file changed, 1 insertion(+)
Peter Korsgaard - Dec. 17, 2012, 11:26 a.m.
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:

 Arnout> 'make source' fails because the host-jpeg-source target doesn't exist
 Arnout> anymore. Fix this by adding this target explicitly.

Committed, thanks.

 Arnout> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 Arnout> ---

 Arnout> Note that this is only necessary because of the rather twisted
 Arnout> way that the top-level target and dependency lists are
 Arnout> generated. Now that all packages have been converted to
 Arnout> gentargets it would probably be possible to create all
 Arnout> necessary dependencies in the package-generic macro, which
 Arnout> would remove the need for this patch.

Agreed.

Patch

diff --git a/package/jpeg/jpeg.mk b/package/jpeg/jpeg.mk
index 9f40e6f..3caacaa 100644
--- a/package/jpeg/jpeg.mk
+++ b/package/jpeg/jpeg.mk
@@ -7,3 +7,4 @@ 
 jpeg: $(if $(BR2_PACKAGE_JPEG_TURBO),jpeg-turbo,libjpeg)
 
 host-jpeg: host-libjpeg
+host-jpeg-source: host-libjpeg-source