Patchwork [U-Boot,2/9] EXYNOS5: FDT: Add DWMMC device node data

login
register
mail settings
Submitter Amar
Date Dec. 17, 2012, 11:19 a.m.
Message ID <1355743176-12305-3-git-send-email-amarendra.xt@samsung.com>
Download mbox | patch
Permalink /patch/206831/
State Superseded
Delegated to: Minkyu Kang
Headers show

Comments

Amar - Dec. 17, 2012, 11:19 a.m.
Add DWMMC device node data for exynos5

Signed-off-by: Amar <amarendra.xt@samsung.com>
---
 arch/arm/dts/exynos5250.dtsi              |   32 +++++++++++++++++++++++++++++
 board/samsung/dts/exynos5250-smdk5250.dts |   24 +++++++++++++++++++++
 2 files changed, 56 insertions(+), 0 deletions(-)
Simon Glass - Dec. 20, 2012, 1:55 a.m.
Hi Amar,

On Mon, Dec 17, 2012 at 3:19 AM, Amar <amarendra.xt@samsung.com> wrote:
> Add DWMMC device node data for exynos5
>
> Signed-off-by: Amar <amarendra.xt@samsung.com>
> ---
>  arch/arm/dts/exynos5250.dtsi              |   32 +++++++++++++++++++++++++++++
>  board/samsung/dts/exynos5250-smdk5250.dts |   24 +++++++++++++++++++++

Do you also have a binding file for this please?

>  2 files changed, 56 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/dts/exynos5250.dtsi b/arch/arm/dts/exynos5250.dtsi
> index 1008797..b701ae5 100644
> --- a/arch/arm/dts/exynos5250.dtsi
> +++ b/arch/arm/dts/exynos5250.dtsi
> @@ -138,4 +138,36 @@
>                 reg = <0x131b0000 0x30>;
>                 interrupts = <0 130 0>;
>         };
> +
> +       dwmmc@12200000 {
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +               compatible = "samsung,exynos5250-dwmmc";
> +               reg = <0x12200000 0x1000>;
> +               interrupts = <0 75 0>;
> +       };
> +
> +       dwmmc@12210000 {
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +               compatible = "samsung,exynos5250-dwmmc";
> +               reg = <0x12210000 0x1000>;
> +               interrupts = <0 76 0>;
> +       };
> +
> +       dwmmc@12220000 {
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +               compatible = "samsung,exynos5250-dwmmc";
> +               reg = <0x12220000 0x1000>;
> +               interrupts = <0 77 0>;
> +       };
> +
> +       dwmmc@12230000 {
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +               compatible = "samsung,exynos5250-dwmmc";
> +               reg = <0x12230000 0x1000>;
> +               interrupts = <0 78 0>;
> +       };
>  };
> diff --git a/board/samsung/dts/exynos5250-smdk5250.dts b/board/samsung/dts/exynos5250-smdk5250.dts
> index a8e62da..b1b8d71 100644
> --- a/board/samsung/dts/exynos5250-smdk5250.dts
> +++ b/board/samsung/dts/exynos5250-smdk5250.dts
> @@ -30,6 +30,10 @@
>                 spi2 = "/spi@12d40000";
>                 spi3 = "/spi@131a0000";
>                 spi4 = "/spi@131b0000";
> +               dwmmc0 = "/dwmmc@12200000";
> +               dwmmc1 = "/dwmmc@12210000";
> +               dwmmc2 = "/dwmmc@12220000";
> +               dwmmc3 = "/dwmmc@12230000";
>         };
>
>         sromc@12250000 {
> @@ -59,4 +63,24 @@
>                         compatible = "wolfson,wm8994-codec";
>                 };
>         };
> +
> +       dwmmc@12200000 {
> +               index = <0>;

Do you really need the index? You have the numbering from the aliaes I think.

> +               bus-width = <8>;
> +               timing = <1 3 3>;

Might need a "samsung," prefix on these?

> +       };
> +
> +       dwmmc@12210000 {
> +               status = "disabled";
> +       };
> +
> +       dwmmc@12220000 {
> +               index = <2>;
> +               bus-width = <4>;
> +               timing = <1 2 3>;
> +       };
> +
> +       dwmmc@12230000 {
> +               status = "disabled";
> +       };
>  };
> --
> 1.7.0.4
>

Regards,
Simon
Jaehoon Chung - Dec. 21, 2012, 9:19 a.m.
On 12/20/2012 10:55 AM, Simon Glass wrote:
> Hi Amar,
> 
> On Mon, Dec 17, 2012 at 3:19 AM, Amar <amarendra.xt@samsung.com> wrote:
>> Add DWMMC device node data for exynos5
>>
>> Signed-off-by: Amar <amarendra.xt@samsung.com>
>> ---
>>  arch/arm/dts/exynos5250.dtsi              |   32 +++++++++++++++++++++++++++++
>>  board/samsung/dts/exynos5250-smdk5250.dts |   24 +++++++++++++++++++++
> 
> Do you also have a binding file for this please?
> 
>>  2 files changed, 56 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/dts/exynos5250.dtsi b/arch/arm/dts/exynos5250.dtsi
>> index 1008797..b701ae5 100644
>> --- a/arch/arm/dts/exynos5250.dtsi
>> +++ b/arch/arm/dts/exynos5250.dtsi
>> @@ -138,4 +138,36 @@
>>                 reg = <0x131b0000 0x30>;
>>                 interrupts = <0 130 0>;
>>         };
>> +
>> +       dwmmc@12200000 {
>> +               #address-cells = <1>;
>> +               #size-cells = <0>;
>> +               compatible = "samsung,exynos5250-dwmmc";
>> +               reg = <0x12200000 0x1000>;
>> +               interrupts = <0 75 0>;
>> +       };
>> +
>> +       dwmmc@12210000 {
>> +               #address-cells = <1>;
>> +               #size-cells = <0>;
>> +               compatible = "samsung,exynos5250-dwmmc";
>> +               reg = <0x12210000 0x1000>;
>> +               interrupts = <0 76 0>;
>> +       };
>> +
>> +       dwmmc@12220000 {
>> +               #address-cells = <1>;
>> +               #size-cells = <0>;
>> +               compatible = "samsung,exynos5250-dwmmc";
>> +               reg = <0x12220000 0x1000>;
>> +               interrupts = <0 77 0>;
>> +       };
>> +
>> +       dwmmc@12230000 {
>> +               #address-cells = <1>;
>> +               #size-cells = <0>;
>> +               compatible = "samsung,exynos5250-dwmmc";
>> +               reg = <0x12230000 0x1000>;
>> +               interrupts = <0 78 0>;
>> +       };
>>  };
>> diff --git a/board/samsung/dts/exynos5250-smdk5250.dts b/board/samsung/dts/exynos5250-smdk5250.dts
>> index a8e62da..b1b8d71 100644
>> --- a/board/samsung/dts/exynos5250-smdk5250.dts
>> +++ b/board/samsung/dts/exynos5250-smdk5250.dts
>> @@ -30,6 +30,10 @@
>>                 spi2 = "/spi@12d40000";
>>                 spi3 = "/spi@131a0000";
>>                 spi4 = "/spi@131b0000";
>> +               dwmmc0 = "/dwmmc@12200000";
>> +               dwmmc1 = "/dwmmc@12210000";
>> +               dwmmc2 = "/dwmmc@12220000";
>> +               dwmmc3 = "/dwmmc@12230000";
>>         };
>>
>>         sromc@12250000 {
>> @@ -59,4 +63,24 @@
>>                         compatible = "wolfson,wm8994-codec";
>>                 };
>>         };
>> +
>> +       dwmmc@12200000 {
>> +               index = <0>;
> 
> Do you really need the index? You have the numbering from the aliaes I think.
> 
>> +               bus-width = <8>;
>> +               timing = <1 3 3>;
> 
> Might need a "samsung," prefix on these?
I think better that use the "exynos" instead of "samsung".
how about?
> 
>> +       };
>> +
>> +       dwmmc@12210000 {
>> +               status = "disabled";
>> +       };
>> +
>> +       dwmmc@12220000 {
>> +               index = <2>;
>> +               bus-width = <4>;
>> +               timing = <1 2 3>;
>> +       };
>> +
>> +       dwmmc@12230000 {
>> +               status = "disabled";
>> +       };
>>  };
>> --
>> 1.7.0.4
>>
> 
> Regards,
> Simon
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
Simon Glass - Dec. 21, 2012, 9:24 p.m.
Hi,

On Fri, Dec 21, 2012 at 1:19 AM, Jaehoon Chung <jh80.chung@samsung.com>wrote:

> On 12/20/2012 10:55 AM, Simon Glass wrote:
> > Hi Amar,
> >
> > On Mon, Dec 17, 2012 at 3:19 AM, Amar <amarendra.xt@samsung.com> wrote:
> >> Add DWMMC device node data for exynos5
> >>
> >> Signed-off-by: Amar <amarendra.xt@samsung.com>
> >> ---
> >>  arch/arm/dts/exynos5250.dtsi              |   32
> +++++++++++++++++++++++++++++
> >>  board/samsung/dts/exynos5250-smdk5250.dts |   24 +++++++++++++++++++++
> >
> > Do you also have a binding file for this please?
> >
> >>  2 files changed, 56 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/arch/arm/dts/exynos5250.dtsi b/arch/arm/dts/exynos5250.dtsi
> >> index 1008797..b701ae5 100644
> >> --- a/arch/arm/dts/exynos5250.dtsi
> >> +++ b/arch/arm/dts/exynos5250.dtsi
> >> @@ -138,4 +138,36 @@
> >>                 reg = <0x131b0000 0x30>;
> >>                 interrupts = <0 130 0>;
> >>         };
> >> +
> >> +       dwmmc@12200000 {
> >> +               #address-cells = <1>;
> >> +               #size-cells = <0>;
> >> +               compatible = "samsung,exynos5250-dwmmc";
> >> +               reg = <0x12200000 0x1000>;
> >> +               interrupts = <0 75 0>;
> >> +       };
> >> +
> >> +       dwmmc@12210000 {
> >> +               #address-cells = <1>;
> >> +               #size-cells = <0>;
> >> +               compatible = "samsung,exynos5250-dwmmc";
> >> +               reg = <0x12210000 0x1000>;
> >> +               interrupts = <0 76 0>;
> >> +       };
> >> +
> >> +       dwmmc@12220000 {
> >> +               #address-cells = <1>;
> >> +               #size-cells = <0>;
> >> +               compatible = "samsung,exynos5250-dwmmc";
> >> +               reg = <0x12220000 0x1000>;
> >> +               interrupts = <0 77 0>;
> >> +       };
> >> +
> >> +       dwmmc@12230000 {
> >> +               #address-cells = <1>;
> >> +               #size-cells = <0>;
> >> +               compatible = "samsung,exynos5250-dwmmc";
> >> +               reg = <0x12230000 0x1000>;
> >> +               interrupts = <0 78 0>;
> >> +       };
> >>  };
> >> diff --git a/board/samsung/dts/exynos5250-smdk5250.dts
> b/board/samsung/dts/exynos5250-smdk5250.dts
> >> index a8e62da..b1b8d71 100644
> >> --- a/board/samsung/dts/exynos5250-smdk5250.dts
> >> +++ b/board/samsung/dts/exynos5250-smdk5250.dts
> >> @@ -30,6 +30,10 @@
> >>                 spi2 = "/spi@12d40000";
> >>                 spi3 = "/spi@131a0000";
> >>                 spi4 = "/spi@131b0000";
> >> +               dwmmc0 = "/dwmmc@12200000";
> >> +               dwmmc1 = "/dwmmc@12210000";
> >> +               dwmmc2 = "/dwmmc@12220000";
> >> +               dwmmc3 = "/dwmmc@12230000";
> >>         };
> >>
> >>         sromc@12250000 {
> >> @@ -59,4 +63,24 @@
> >>                         compatible = "wolfson,wm8994-codec";
> >>                 };
> >>         };
> >> +
> >> +       dwmmc@12200000 {
> >> +               index = <0>;
> >
> > Do you really need the index? You have the numbering from the aliaes I
> think.
> >
> >> +               bus-width = <8>;
> >> +               timing = <1 3 3>;
> >
> > Might need a "samsung," prefix on these?
> I think better that use the "exynos" instead of "samsung".
> how about?
>

Well I think you are supposed to use vendor,propname when you define your
own private binding.


> >
> >> +       };
> >> +
> >> +       dwmmc@12210000 {
> >> +               status = "disabled";
> >> +       };
> >> +
> >> +       dwmmc@12220000 {
> >> +               index = <2>;
> >> +               bus-width = <4>;
> >> +               timing = <1 2 3>;
> >> +       };
> >> +
> >> +       dwmmc@12230000 {
> >> +               status = "disabled";
> >> +       };
> >>  };
> >> --
> >> 1.7.0.4
> >>
> >
> > Regards,
> > Simon
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot@lists.denx.de
> > http://lists.denx.de/mailman/listinfo/u-boot
> >
>
>
Amarendra Reddy - Dec. 24, 2012, 6:54 a.m.
Hi

On 22 December 2012 02:54, Simon Glass <sjg@chromium.org> wrote:

> Hi,
>
> On Fri, Dec 21, 2012 at 1:19 AM, Jaehoon Chung <jh80.chung@samsung.com
> >wrote:
>
> > On 12/20/2012 10:55 AM, Simon Glass wrote:
> > > Hi Amar,
> > >
> > > On Mon, Dec 17, 2012 at 3:19 AM, Amar <amarendra.xt@samsung.com>
> wrote:
> > >> Add DWMMC device node data for exynos5
> > >>
> > >> Signed-off-by: Amar <amarendra.xt@samsung.com>
> > >> ---
> > >>  arch/arm/dts/exynos5250.dtsi              |   32
> > +++++++++++++++++++++++++++++
> > >>  board/samsung/dts/exynos5250-smdk5250.dts |   24
> +++++++++++++++++++++
> > >
> > > Do you also have a binding file for this please?
> > >
> > >>  2 files changed, 56 insertions(+), 0 deletions(-)
> > >>
> > >> diff --git a/arch/arm/dts/exynos5250.dtsi
> b/arch/arm/dts/exynos5250.dtsi
> > >> index 1008797..b701ae5 100644
> > >> --- a/arch/arm/dts/exynos5250.dtsi
> > >> +++ b/arch/arm/dts/exynos5250.dtsi
> > >> @@ -138,4 +138,36 @@
> > >>                 reg = <0x131b0000 0x30>;
> > >>                 interrupts = <0 130 0>;
> > >>         };
> > >> +
> > >> +       dwmmc@12200000 {
> > >> +               #address-cells = <1>;
> > >> +               #size-cells = <0>;
> > >> +               compatible = "samsung,exynos5250-dwmmc";
> > >> +               reg = <0x12200000 0x1000>;
> > >> +               interrupts = <0 75 0>;
> > >> +       };
> > >> +
> > >> +       dwmmc@12210000 {
> > >> +               #address-cells = <1>;
> > >> +               #size-cells = <0>;
> > >> +               compatible = "samsung,exynos5250-dwmmc";
> > >> +               reg = <0x12210000 0x1000>;
> > >> +               interrupts = <0 76 0>;
> > >> +       };
> > >> +
> > >> +       dwmmc@12220000 {
> > >> +               #address-cells = <1>;
> > >> +               #size-cells = <0>;
> > >> +               compatible = "samsung,exynos5250-dwmmc";
> > >> +               reg = <0x12220000 0x1000>;
> > >> +               interrupts = <0 77 0>;
> > >> +       };
> > >> +
> > >> +       dwmmc@12230000 {
> > >> +               #address-cells = <1>;
> > >> +               #size-cells = <0>;
> > >> +               compatible = "samsung,exynos5250-dwmmc";
> > >> +               reg = <0x12230000 0x1000>;
> > >> +               interrupts = <0 78 0>;
> > >> +       };
> > >>  };
> > >> diff --git a/board/samsung/dts/exynos5250-smdk5250.dts
> > b/board/samsung/dts/exynos5250-smdk5250.dts
> > >> index a8e62da..b1b8d71 100644
> > >> --- a/board/samsung/dts/exynos5250-smdk5250.dts
> > >> +++ b/board/samsung/dts/exynos5250-smdk5250.dts
> > >> @@ -30,6 +30,10 @@
> > >>                 spi2 = "/spi@12d40000";
> > >>                 spi3 = "/spi@131a0000";
> > >>                 spi4 = "/spi@131b0000";
> > >> +               dwmmc0 = "/dwmmc@12200000";
> > >> +               dwmmc1 = "/dwmmc@12210000";
> > >> +               dwmmc2 = "/dwmmc@12220000";
> > >> +               dwmmc3 = "/dwmmc@12230000";
> > >>         };
> > >>
> > >>         sromc@12250000 {
> > >> @@ -59,4 +63,24 @@
> > >>                         compatible = "wolfson,wm8994-codec";
> > >>                 };
> > >>         };
> > >> +
> > >> +       dwmmc@12200000 {
> > >> +               index = <0>;
> > >
> > > Do you really need the index? You have the numbering from the aliaes I
> > think.
> > >
> > >> +               bus-width = <8>;
> > >> +               timing = <1 3 3>;
> > >
> > > Might need a "samsung," prefix on these?
> > I think better that use the "exynos" instead of "samsung".
> > how about?
> >
>
> Well I think you are supposed to use vendor,propname when you define your
> own private binding.
>
> Ok, I shall use "samsung," prefix.

>
> > >
> > >> +       };
> > >> +
> > >> +       dwmmc@12210000 {
> > >> +               status = "disabled";
> > >> +       };
> > >> +
> > >> +       dwmmc@12220000 {
> > >> +               index = <2>;
> > >> +               bus-width = <4>;
> > >> +               timing = <1 2 3>;
> > >> +       };
> > >> +
> > >> +       dwmmc@12230000 {
> > >> +               status = "disabled";
> > >> +       };
> > >>  };
> > >> --
> > >> 1.7.0.4
> > >>
> > >
> > > Regards,
> > > Simon
> > > _______________________________________________
> > > U-Boot mailing list
> > > U-Boot@lists.denx.de
> > > http://lists.denx.de/mailman/listinfo/u-boot
> > >
> >
> >
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
>
Thanks & Regards
Amarendra Reddy

Patch

diff --git a/arch/arm/dts/exynos5250.dtsi b/arch/arm/dts/exynos5250.dtsi
index 1008797..b701ae5 100644
--- a/arch/arm/dts/exynos5250.dtsi
+++ b/arch/arm/dts/exynos5250.dtsi
@@ -138,4 +138,36 @@ 
 		reg = <0x131b0000 0x30>;
 		interrupts = <0 130 0>;
 	};
+
+	dwmmc@12200000 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "samsung,exynos5250-dwmmc";
+		reg = <0x12200000 0x1000>;
+		interrupts = <0 75 0>;
+	};
+
+	dwmmc@12210000 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "samsung,exynos5250-dwmmc";
+		reg = <0x12210000 0x1000>;
+		interrupts = <0 76 0>;
+	};
+
+	dwmmc@12220000 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "samsung,exynos5250-dwmmc";
+		reg = <0x12220000 0x1000>;
+		interrupts = <0 77 0>;
+	};
+
+	dwmmc@12230000 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "samsung,exynos5250-dwmmc";
+		reg = <0x12230000 0x1000>;
+		interrupts = <0 78 0>;
+	};
 };
diff --git a/board/samsung/dts/exynos5250-smdk5250.dts b/board/samsung/dts/exynos5250-smdk5250.dts
index a8e62da..b1b8d71 100644
--- a/board/samsung/dts/exynos5250-smdk5250.dts
+++ b/board/samsung/dts/exynos5250-smdk5250.dts
@@ -30,6 +30,10 @@ 
 		spi2 = "/spi@12d40000";
 		spi3 = "/spi@131a0000";
 		spi4 = "/spi@131b0000";
+		dwmmc0 = "/dwmmc@12200000";
+		dwmmc1 = "/dwmmc@12210000";
+		dwmmc2 = "/dwmmc@12220000";
+		dwmmc3 = "/dwmmc@12230000";
 	};
 
 	sromc@12250000 {
@@ -59,4 +63,24 @@ 
 			compatible = "wolfson,wm8994-codec";
 		};
 	};
+
+	dwmmc@12200000 {
+		index = <0>;
+		bus-width = <8>;
+		timing = <1 3 3>;
+	};
+
+	dwmmc@12210000 {
+		status = "disabled";
+	};
+
+	dwmmc@12220000 {
+		index = <2>;
+		bus-width = <4>;
+		timing = <1 2 3>;
+	};
+
+	dwmmc@12230000 {
+		status = "disabled";
+	};
 };